This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Remove orphan ByteString Listable instance. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2019 11:53
This was created with a whole mess of Leancheck combinators. A Hedgehog approach makes things easier.
patrickt
commented
Jun 14, 2019
| prop "covers multiple lines" $ | ||
| \ n -> totalSpan (fromText (Text.intersperse '\n' (Text.replicate n "*"))) `shouldBe` Span (Pos 1 1) (Pos (max 1 n) (if n > 0 then 2 else 1)) | ||
|
|
||
| describe "newlineIndices" $ do |
Contributor
Author
There was a problem hiding this comment.
In keeping with my philosophy of “do as little as possible so I don’t end up rewriting the whole test suite in an act of Pyrrhic futility”, I’ve left the tests that didn’t use LeanCheck as specs with describe.
| import qualified Data.Source | ||
| import Data.Functor.Identity | ||
|
|
||
| source :: (GenBase m ~ Identity, MonadGen m) => Hedgehog.Range Int -> m Data.Source.Source |
Contributor
Author
There was a problem hiding this comment.
The GenBase constraint is a weird artifact of the Hedgehog API.
| import qualified Test.Tasty as Tasty | ||
| import Test.Tasty.Hedgehog (testProperty) | ||
|
|
||
| prop :: HasCallStack => String -> (Source -> PropertyT IO ()) -> Tasty.TestTree |
Contributor
Author
There was a problem hiding this comment.
Wrote this little helper to save keystrokes and modify as few of the specs as possible.
| @@ -0,0 +1,12 @@ | |||
| {-# LANGUAGE TypeFamilies #-} | |||
| module Generators | |||
Contributor
Author
There was a problem hiding this comment.
I figure we’re gonna have a lot of generators, many of which may depend on each other.
robrix
approved these changes
Jun 14, 2019
| import qualified Test.Tasty as Tasty | ||
| import Test.Tasty.Hedgehog (testProperty) | ||
|
|
||
| prop :: HasCallStack => String -> (Source -> PropertyT IO ()) -> Tasty.TestTree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we begin to transition to Hedgehog (#122), this instance stood out as one we could absolutely delete: it’s a roundabout way of expressing what we mean in the Data.Source tests, namely that we want to generate random UTF-8 ByteStrings and run our computations over them.