Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX namespace names #399

Merged
merged 5 commits into from
Feb 9, 2024
Merged

JSX namespace names #399

merged 5 commits into from
Feb 9, 2024

Conversation

robrix
Copy link
Contributor

@robrix robrix commented Feb 9, 2024

JSX elements can have namespaces names, which have accordingly different CST.

@robrix robrix requested a review from a team as a code owner February 9, 2024 18:12
node @name.after_scope

edge @lhs.before_scope -> @name.before_scope
edge @rhs.before_scope -> @lhs.after_scope
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this one. My thinking is that the namespace (@lhs) might resolve to a node in which @rhs can then be resolved 🤷🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…about this specific line, I should say.

@robrix robrix merged commit b61bb84 into main Feb 9, 2024
8 checks passed
@robrix robrix deleted the jsx-namespace-names branch February 9, 2024 20:08
@SimegnAbay
Copy link

SimegnAbay commented Feb 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants