do less work if not sampled #1

Merged
merged 1 commit into from Dec 30, 2011

Projects

None yet

2 participants

@gburt

no need to do regexes etc if we're not sampled; tests pass

@technoweenie
GitHub member

Thanks for the patch. Are you considering sending this to @reinh? It's his gem -- this is a fork we maintain for internal use.

@technoweenie technoweenie merged commit 1b945ac into github:master Dec 30, 2011
@gburt

Hrm, if I do a pull-request to @reinh's repo it brings your changes in as well. Are you planning to pull-req your fork upstream?

@technoweenie
GitHub member

Zing! I'm not sure. Don't worry about it then :)

@quirkey quirkey pushed a commit to paperlesspost/statsd-ruby that referenced this pull request Mar 5, 2014
@jeremy jeremy Do less work if this stat isn't sampled anyway. h/t github#1 3e0125a
@quirkey quirkey pushed a commit to paperlesspost/statsd-ruby that referenced this pull request Mar 5, 2014
@raggi raggi Merge branch 'jeremy'
* jeremy: (37 commits)
  Remove bogus self-dependency. WTF jeweler?
  Update generated .gemspec too
  Update gemspec info. Use fork URL.
  Socket error handling specs
  Ignore socket errors even if logger is not set.
  Update Bundler install docs to use github: source and limit to ~> 0.4.0
  Bundler installation instructions
  missing spec and doc for guage
  Change rcov to simplecov for compatibility with ruby 1.9
  README cosmetics
  Remove rcov dep
  Travis CI
  Bump to 0.4.0. Shed the .signals prerelease tag.
  Do less work if this stat isn't sampled anyway. h/t github#1
  Bundle up dependencies to run tests
  Revert "Resolve non-IP hosts to an IP immediately rather than incur a DNS lookup for each socket send"
  Fix exception handling specs
  Add an exception handling module so statsd can't disrupt the code it's monitoring.
  Setting host or port to nil sets to defaults
  Allow setting a nil host. Will resolve to localhost ultimately.
  ...

Conflicts:
	lib/statsd.rb
	statsd-ruby.gemspec
4c323da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment