Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Git to update major version and latest tags #3376

Merged
merged 3 commits into from Sep 30, 2022
Merged

Conversation

ferrarimarco
Copy link
Collaborator

Fixes #3372

Proposed Changes

  1. Use Git to update the vMAJOR_VERSION and latest Git tags instead of relying on an action.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

admiralAwkbar
admiralAwkbar previously approved these changes Sep 30, 2022
Copy link
Collaborator

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very fancy

@ferrarimarco
Copy link
Collaborator Author

@admiralAwkbar sorry for bothering you again. Mind having another look? I've pushed another commit to streamline things a bit. Thanks!

Copy link
Collaborator

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very dank

@ferrarimarco ferrarimarco merged commit ccf58d2 into main Sep 30, 2022
9 checks passed
@ferrarimarco ferrarimarco deleted the fix-release-tagging branch September 30, 2022 17:55
@ferrarimarco
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The version updater workflow fails with permission issues
2 participants