This repository has been archived by the owner on Nov 1, 2017. It is now read-only.
Don't add task-list class to lists that don't contain tasks #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woops, duplicate of #58. |
rspeicher
added a commit
to gitlabhq/gitlabhq
that referenced
this pull request
May 21, 2015
Instead of using a fork, we subclass the filter and only apply the `task-list` class to list items that actually are task lists. Closes #1645 See github/task_list#60
dzaporozhets
added a commit
to gitlabhq/gitlabhq
that referenced
this pull request
May 21, 2015
Use task_list fork to fix list items in notes Closes #1645 See github/task_list#60 See merge request !680
rspeicher
added a commit
to gitlabhq/gitlabhq
that referenced
this pull request
May 27, 2015
Instead of using a fork, we subclass the filter and only apply the `task-list` class to list items that actually are task lists. Closes #1645 See github/task_list#60
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter was adding the
task-listclass to all list elements regardless ofwhether or not they contained task lists.