Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the package as side-effects free #8

Closed
wants to merge 1 commit into from
Closed

Conversation

stof
Copy link

@stof stof commented Oct 31, 2019

This helps Rollup and webpack when performing tree-shaking.

This helps Rollup and webpack when performing tree-shaking.
@koddsson
Copy link
Contributor

koddsson commented Nov 1, 2019

Can you link to any documentation about this attribute? I can't find any on the rollup page or when searching the web for it.

@stof
Copy link
Author

stof commented Nov 18, 2019

See https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free for the webpack doc about it.
Rollup added support for this flag in their tree-shaking algorithm, but I don't think they have written documentation about it (other than a changelog line saying it is supported).

@koddsson
Copy link
Contributor

Rollup added support for this flag in their tree-shaking algorithm, but I don't think they have written documentation about it (other than a changelog line saying it is supported).

Can you link to the changelog line? I Couldn't find it in the CHANGELOG.md or in any of the pull requests on rollup/rollup.

@stof
Copy link
Author

stof commented Nov 25, 2019

@koddsson
Copy link
Contributor

Hey @stof I appreciate the PR but we aren't using rollup or rollup-plugin-node-resolve in this project any more.

@koddsson koddsson closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants