Readme logo update

[dylanatsmith]

Summary

Takes advantage of GitHub’s newly supported functionality to show/hide images in Markdown depending on which GH theme is served as per user settings.

• Feature documentaion
• Community request thread

Further optimises the solution to #1134 shipped in #1143.

Note: There doesn't seem to be a way, at least in GFM, to specify image size. So using exising assets they'll be full-width unless we create smaller ones for this purpose.

[Spone]

Great that this feature shipped!

Note: There doesn't seem to be a way, at least in GFM, to specify image size. So using exising assets they'll be full-width unless we create smaller ones for this purpose.

It's a bit large for the README, don't you think?

What about changing the width="735" height="84" viewBox="0 0 735 84" values in the existing assets? Since it's SVG there will be no quality loss if people want to use them at larger size in other contexts.

[dylanatsmith]

It's nearly comical on desktop for sure.

Changing the canonical SVG is an option. I don’t think there’d be any side effects. I don’t love the idea of adding those attributes to satisfy this one use case, just on principle, but I’m not opposed.

I think we do one of the following:

1. Leave it full-width in the readme
2. Change the size of the canonical SVG
3. Add additional, readme-specific assets like we’re currently using

I’m leaning toward option 3 at the moment but I’m open.

[BlakeWilliams]

I'm 👍 on option 3, using assets specifically for the README makes sense to me.

[joelhawksley]

I'm fine with option 3 as well 👍🏻