Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI feedback when there are 0 alerts #236

Closed
adityasharad opened this issue Feb 12, 2020 · 0 comments
Closed

Improve UI feedback when there are 0 alerts #236

adityasharad opened this issue Feb 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@adityasharad
Copy link
Contributor

Is your feature request related to a problem? Please describe.
While developing and running a query, it is possible to have 0 results in the formatted alerts table, but a non-zero number of tuples in the #select table. This can happen if the selected entity is missing location information, or if there is a mismatch between the query metadata and the columns in the select clause. This commonly trips up both new and experienced writers and leads to time wasted debugging the query's logic.

Describe the solution you'd like

  • Make it obvious to the user how many results are in each of the result tables, regardless of which result table is currently being displayed in full.
  • Suggest the user checks the query metadata/result patterns if there is a mismatch with 0 alerts.

Describe alternatives you've considered
Alternatively, make 0 alerts a special case, and in this case have an annotation pointing the user to the #select table or the table dropdown.

Additional context
@adityasharad adityasharad added the enhancement New feature or request label Feb 12, 2020
aeisenberg added a commit to aeisenberg/vscode-codeql that referenced this issue Mar 18, 2020
@aeisenberg
feat: Adds command to show query log in editor
a034866 
Right clicking on the history page will now have a new option to show
the associated log.

Closes github#236
Closes github#234
aeisenberg added a commit to aeisenberg/vscode-codeql that referenced this issue Mar 18, 2020
@aeisenberg
feat: Adds command to show query log in editor
e23b5fa 
Right clicking on the history page will now have a new option to show
the associated log.

Closes github#236
Closes github#234
aeisenberg added a commit to aeisenberg/vscode-codeql that referenced this issue Mar 18, 2020
@aeisenberg
feat: Remove side log location when query removed
d2393f0 
When removing query history item from view, also remove the side log.

Log files can be large, so ensure they don't stick around.

Last piece of github#236 and github#234.
aeisenberg added a commit to aeisenberg/vscode-codeql that referenced this issue Mar 19, 2020
@aeisenberg
feat: Remove side log location when query removed
66e9272 
When removing query history item from view, also remove the side log.

Log files can be large, so ensure they don't stick around.

Last piece of github#236 and github#234.
@snyk-bot snyk-bot mentioned this issue Aug 28, 2020
Open
@snyk-bot snyk-bot mentioned this issue Oct 8, 2020
Open
@snyk-bot snyk-bot mentioned this issue Dec 19, 2020
Open
@dizzydaizy dizzydaizy mentioned this issue Mar 13, 2021
Open
This was referenced Sep 10, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adityasharad