diff --git a/extensions/ql-vscode/src/databases/ui/db-tree-view-item.ts b/extensions/ql-vscode/src/databases/ui/db-tree-view-item.ts index f0e5cf8d110..67e7161f99b 100644 --- a/extensions/ql-vscode/src/databases/ui/db-tree-view-item.ts +++ b/extensions/ql-vscode/src/databases/ui/db-tree-view-item.ts @@ -15,8 +15,11 @@ import { */ export class DbTreeViewItem extends vscode.TreeItem { constructor( + // iconPath and tooltip must have those names because + // they are part of the vscode.TreeItem interface + public readonly dbItem: DbItem | undefined, - public readonly icon: vscode.ThemeIcon | undefined, + public readonly iconPath: vscode.ThemeIcon | undefined, public readonly label: string, public readonly tooltip: string | undefined, public readonly collapsibleState: vscode.TreeItemCollapsibleState, diff --git a/extensions/ql-vscode/src/vscode-tests/minimal-workspace/databases/db-panel.test.ts b/extensions/ql-vscode/src/vscode-tests/minimal-workspace/databases/db-panel.test.ts index 6337861c43e..9ec8883ced4 100644 --- a/extensions/ql-vscode/src/vscode-tests/minimal-workspace/databases/db-panel.test.ts +++ b/extensions/ql-vscode/src/vscode-tests/minimal-workspace/databases/db-panel.test.ts @@ -230,7 +230,7 @@ describe('db panel', async () => { ): void { expect(item.label).to.equal(`Top ${n} repositories`); expect(item.tooltip).to.equal(`Top ${n} repositories of a language`); - expect(item.icon).to.deep.equal(new vscode.ThemeIcon('github')); + expect(item.iconPath).to.deep.equal(new vscode.ThemeIcon('github')); expect(item.collapsibleState).to.equal(vscode.TreeItemCollapsibleState.None); } @@ -241,7 +241,7 @@ describe('db panel', async () => { ): void { expect(item.label).to.equal(listName); expect(item.tooltip).to.be.undefined; - expect(item.icon).to.be.undefined; + expect(item.iconPath).to.be.undefined; expect(item.collapsibleState).to.equal(vscode.TreeItemCollapsibleState.Collapsed); expect(item.children).to.be.ok; expect(item.children.length).to.equal(repos.length); @@ -257,7 +257,7 @@ describe('db panel', async () => { ): void { expect(item.label).to.equal(ownerName); expect(item.tooltip).to.be.undefined; - expect(item.icon).to.deep.equal(new vscode.ThemeIcon('organization')); + expect(item.iconPath).to.deep.equal(new vscode.ThemeIcon('organization')); expect(item.collapsibleState).to.equal(vscode.TreeItemCollapsibleState.None); expect(item.children).to.be.ok; expect(item.children.length).to.equal(0); @@ -269,7 +269,7 @@ describe('db panel', async () => { ): void { expect(item.label).to.equal(repoName); expect(item.tooltip).to.be.undefined; - expect(item.icon).to.deep.equal(new vscode.ThemeIcon('database')); + expect(item.iconPath).to.deep.equal(new vscode.ThemeIcon('database')); expect(item.collapsibleState).to.equal(vscode.TreeItemCollapsibleState.None); } });