From 1d4cbde48eb4f37be4699e4923fd9678916f574f Mon Sep 17 00:00:00 2001 From: Robert Date: Fri, 2 Dec 2022 12:45:52 +0000 Subject: [PATCH] Check variant analysis status in isVariantAnalysisComplete --- .../src/remote-queries/shared/variant-analysis.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts b/extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts index 65193d29ab3..7641efd2ade 100644 --- a/extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts +++ b/extensions/ql-vscode/src/remote-queries/shared/variant-analysis.ts @@ -165,13 +165,15 @@ export async function isVariantAnalysisComplete( repo: VariantAnalysisScannedRepository, ) => Promise, ): Promise { - // It's only acceptable to have no scanned repos if the variant analysis is not in a final state. - // Otherwise it means the analysis hit some kind of internal error or there were no repos to scan. + if (!isFinalVariantAnalysisStatus(variantAnalysis.status)) { + return false; + } + if ( variantAnalysis.scannedRepos === undefined || variantAnalysis.scannedRepos.length === 0 ) { - return variantAnalysis.status !== VariantAnalysisStatus.InProgress; + return true; } return (