From 55b1f37b4e8e3a4db4dc0a7b19428a960c516670 Mon Sep 17 00:00:00 2001 From: shati-patel <42641846+shati-patel@users.noreply.github.com> Date: Fri, 20 Jan 2023 17:49:41 +0000 Subject: [PATCH 1/2] Don't lint actions-generated file --- extensions/ql-vscode/.prettierignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/extensions/ql-vscode/.prettierignore b/extensions/ql-vscode/.prettierignore index a362ef891c5..b463ca69e2a 100644 --- a/extensions/ql-vscode/.prettierignore +++ b/extensions/ql-vscode/.prettierignore @@ -2,5 +2,9 @@ node_modules/ out/ +# This file gets written by an actions workflow. +# Don't try to format it. +supported_cli_versions.json + # Include the Storybook config !.storybook From 7132c50068b50e0225f28c030018d34bc86c9eaf Mon Sep 17 00:00:00 2001 From: shati-patel <42641846+shati-patel@users.noreply.github.com> Date: Fri, 20 Jan 2023 17:54:50 +0000 Subject: [PATCH 2/2] Open github-actions PRs as draft CI doesn't run on PRs opened by the github-actions bot, so we need a human to manually prod them. Our existing approach (e.g. in the releases workflow) is to open the bot PR as a draft, and then run CI when a human marks it as ready-for-review. --- .github/actions/create-pr/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/create-pr/action.yml b/.github/actions/create-pr/action.yml index 87fde3f5266..c4b9ca4d3d9 100644 --- a/.github/actions/create-pr/action.yml +++ b/.github/actions/create-pr/action.yml @@ -75,7 +75,7 @@ runs: echo "Found existing open PR: $PR_NUMBERS" exit 0 fi - gh pr create --head "$HEAD_BRANCH" --base "$BASE_BRANCH" --title "$TITLE" --body "$BODY" --assignee ${{ github.actor }} + gh pr create --head "$HEAD_BRANCH" --base "$BASE_BRANCH" --title "$TITLE" --body "$BODY" --assignee ${{ github.actor }} --draft if [[ $? -ne 0 ]]; then echo "Failed to create new PR." exit 1