From d574f3d94cb818f9e1e63a5967c32acafc02c2ec Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Thu, 2 Mar 2023 12:32:45 +0100 Subject: [PATCH] Fix error while deleting query history item When deleting a query history item and the "next" query is still running, the `completedQuery` is `undefined`. This commit fixes it by using optional chaining to ensure that the `completedQuery` is defined before accessing its `successful` property. --- extensions/ql-vscode/src/interface.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/interface.ts b/extensions/ql-vscode/src/interface.ts index a3389fdfa63..17655fa7c7c 100644 --- a/extensions/ql-vscode/src/interface.ts +++ b/extensions/ql-vscode/src/interface.ts @@ -399,7 +399,7 @@ export class ResultsView extends AbstractWebview< forceReveal: WebviewReveal, shouldKeepOldResultsWhileRendering = false, ): Promise { - if (!fullQuery.completedQuery.successful) { + if (!fullQuery.completedQuery?.successful) { return; }