From 62226358ca56fd7d5282185233a63402b5e7c5d3 Mon Sep 17 00:00:00 2001 From: shati-patel <42641846+shati-patel@users.noreply.github.com> Date: Fri, 14 Jul 2023 14:30:11 +0100 Subject: [PATCH 1/2] Add "symbol-misc" icon SVG borrowed from https://github.com/microsoft/vscode-codicons --- extensions/ql-vscode/media/dark/symbol-misc.svg | 1 + extensions/ql-vscode/media/light/symbol-misc.svg | 1 + 2 files changed, 2 insertions(+) create mode 100644 extensions/ql-vscode/media/dark/symbol-misc.svg create mode 100644 extensions/ql-vscode/media/light/symbol-misc.svg diff --git a/extensions/ql-vscode/media/dark/symbol-misc.svg b/extensions/ql-vscode/media/dark/symbol-misc.svg new file mode 100644 index 00000000000..39768b373c5 --- /dev/null +++ b/extensions/ql-vscode/media/dark/symbol-misc.svg @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/extensions/ql-vscode/media/light/symbol-misc.svg b/extensions/ql-vscode/media/light/symbol-misc.svg new file mode 100644 index 00000000000..4f30771fc21 --- /dev/null +++ b/extensions/ql-vscode/media/light/symbol-misc.svg @@ -0,0 +1 @@ + \ No newline at end of file From fb4e7ac1ae3a0e17c830fd0b06e515aaeb5eb3f7 Mon Sep 17 00:00:00 2001 From: shati-patel <42641846+shati-patel@users.noreply.github.com> Date: Fri, 14 Jul 2023 14:31:46 +0100 Subject: [PATCH 2/2] Set "symbol-misc" as the data extension's icon --- .../ql-vscode/src/common/vscode/abstract-webview.ts | 3 +++ .../data-extensions-editor/data-extensions-editor-view.ts | 8 ++++++++ 2 files changed, 11 insertions(+) diff --git a/extensions/ql-vscode/src/common/vscode/abstract-webview.ts b/extensions/ql-vscode/src/common/vscode/abstract-webview.ts index 385ee253370..8bd476fca71 100644 --- a/extensions/ql-vscode/src/common/vscode/abstract-webview.ts +++ b/extensions/ql-vscode/src/common/vscode/abstract-webview.ts @@ -19,6 +19,7 @@ export type WebviewPanelConfig = { viewColumn: ViewColumn; view: WebviewView; preserveFocus?: boolean; + iconPath?: Uri | { dark: Uri; light: Uri }; additionalOptions?: WebviewPanelOptions & WebviewOptions; allowWasmEval?: boolean; }; @@ -86,6 +87,8 @@ export abstract class AbstractWebview< ); this.panel = panel; + this.panel.iconPath = config.iconPath; + this.setupPanel(panel, config); this.panelResolves.forEach((resolve) => resolve(panel)); diff --git a/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts b/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts index bc5e4580b6a..86282470289 100644 --- a/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts +++ b/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts @@ -84,6 +84,14 @@ export class DataExtensionsEditorView extends AbstractWebview< viewColumn: ViewColumn.Active, preserveFocus: true, view: "data-extensions-editor", + iconPath: { + dark: Uri.file( + join(this.ctx.extensionPath, "media/dark/symbol-misc.svg"), + ), + light: Uri.file( + join(this.ctx.extensionPath, "media/light/symbol-misc.svg"), + ), + }, }; }