diff --git a/extensions/ql-vscode/package.json b/extensions/ql-vscode/package.json index dca70ea15b4..696abc6ab4c 100644 --- a/extensions/ql-vscode/package.json +++ b/extensions/ql-vscode/package.json @@ -1763,7 +1763,7 @@ { "id": "codeQLModelDetails", "name": "CodeQL Model Details", - "when": "config.codeQL.canary && config.codeQL.dataExtensions.modelDetailsView && codeql.dataExtensionsEditorOpen" + "when": "config.codeQL.canary && codeql.dataExtensionsEditorOpen" } ] }, diff --git a/extensions/ql-vscode/src/config.ts b/extensions/ql-vscode/src/config.ts index 8c3c684d0dd..dd2e813d383 100644 --- a/extensions/ql-vscode/src/config.ts +++ b/extensions/ql-vscode/src/config.ts @@ -713,11 +713,6 @@ const EXTENSIONS_DIRECTORY = new Setting( "extensionsDirectory", DATA_EXTENSIONS, ); -const MODEL_DETAILS_VIEW = new Setting("modelDetailsView", DATA_EXTENSIONS); - -export function showModelDetailsView(): boolean { - return !!MODEL_DETAILS_VIEW.getValue(); -} export function showLlmGeneration(): boolean { return !!LLM_GENERATION.getValue(); diff --git a/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts b/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts index 94d25ac32b5..5fddbe0cc43 100644 --- a/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts +++ b/extensions/ql-vscode/src/data-extensions-editor/data-extensions-editor-view.ts @@ -32,11 +32,7 @@ import { readQueryResults, runQuery } from "./external-api-usage-query"; import { ExternalApiUsage, Usage } from "./external-api-usage"; import { ModeledMethod } from "./modeled-method"; import { ExtensionPack } from "./shared/extension-pack"; -import { - enableFrameworkMode, - showLlmGeneration, - showModelDetailsView, -} from "../config"; +import { enableFrameworkMode, showLlmGeneration } from "../config"; import { Mode } from "./shared/mode"; import { loadModeledMethods, saveModeledMethods } from "./modeled-method-fs"; import { join } from "path"; @@ -280,9 +276,7 @@ export class DataExtensionsEditorView extends AbstractWebview< } protected async handleJumpToUsage(usage: Usage) { - if (showModelDetailsView()) { - await this.revealItemInDetailsPanel(usage); - } + await this.revealItemInDetailsPanel(usage); await showResolvableLocation(usage.url, this.databaseItem, this.app.logger); }