Skip to content

Adjust styling of disabled dropdowns to make their state clearer #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2023
Merged

Adjust styling of disabled dropdowns to make their state clearer #2779

merged 3 commits into from
Sep 5, 2023

Conversation

@robertbrignull
Copy link
Contributor

@robertbrignull robertbrignull commented Sep 4, 2023

This PR makes three changes to dropdowns:

  • When disabled, shows a dash/hyphen instead of nothing
  • When disabled, sets the opacity value lower (this matches how the VSCodeDropdown component behaves)
  • Moves the arrow further away from the right-hand edge

Screenshot:
Screenshot 2023-09-04 at 15 21 16

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team September 4, 2023 14:27
@robertbrignull robertbrignull requested a review from a team as a code owner September 4, 2023 14:27
shati-patel
shati-patel approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Tested locally too 🖼️

@robertbrignull robertbrignull merged commit 247ba4e into main Sep 5, 2023
@robertbrignull robertbrignull deleted the robertbrignull/dropdown-disabled branch September 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertbrignull @shati-patel