Copy more files into the synthetic variant analysis pack #2786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change and starting with CLI v2.14.3, if you wanted to run a variant analysis query and the pack it is contained in has at least one query that contains an extensible predicate, this would be an error. The reason is that v2.14.3 introduced deep validation for data extensions. We are not copying the query that contains an extensible predicate to the synthetic pack we are generating. This means that deep validation will fail because there will be extensions that target the missing extensible predicate. This change avoids the problem by copying any query files that contain extensible predicates to the synthetic pack. It uses the internal `generate extensible-predicate-metadata` command to discover which query files contain extensible predicates and copies them.
aeisenberg
force-pushed
the
aeisenberg/extensible-predicate-metadata
branch
from
9166e6a to
d8fb227
Compare
Contributor
Author
|
@robertbrignull would you be able to look at this? |
robertbrignull
approved these changes
Sep 8, 2023
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I don't know as much as some about what effects could happen by including a query file in the pack, but I trust you it's the right thing to do. I did manage to reproduce the error and verify that this branch fixes it.
Contributor
Author
|
Thanks for looking into this. The only (mildly) negative effect is that because we are including more query files in the synthetic query pack, we will need to compile more queries and generating the pack will take slightly longer. However, these queries are ignored since they are not part of the default query suite that is run by the variant analysis runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change and starting with CLI v2.14.3, if you wanted to run a variant analysis query and the pack it is contained in has at least one query that contains an extensible predicate, this would be an error.
The reason is that v2.14.3 introduced deep validation for data extensions. We are not copying the query that contains an extensible predicate to the synthetic pack we are generating. This means that deep validation will fail because there will be extensions that target the missing extensible predicate.
This change avoids the problem by copying any query files that contain extensible predicates to the synthetic pack. It uses the internal
generate extensible-predicate-metadatacommand to discover which query files contain extensible predicates and copies them.Checklist
ready-for-doc-reviewlabel there.