Skip to content

Conversation

@shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Sep 11, 2023

Patch release to include the changes from #2786.

A few changed files:

  • Changelog entry (it ended up in the wrong section due to a bad merge from main).
  • I've updated the node version in all the workflows and package files.
  • I've updated the releasing.md instructions to include all the files that are affected by the node version.

Checklist

N/A

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner September 11, 2023 11:40
@shati-patel
Copy link
Contributor Author

Ugh, it looks like the new node version is breaking things 🤦🏽 ( HttpError: location is not defined)

@shati-patel
Copy link
Contributor Author

Ugh, it looks like the new node version is breaking things 🤦🏽 ( HttpError: location is not defined)

We're going to need to update the node version soon (since the bug will happen for anyone using the new version locally), but let's leave that for a separate PR.

Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've found the cause of the "Location is not defined" bug and thankfully we can work around it. It only happens in the codeQL.mockGitHubApiServer feature is enabled, which is made for developer testing, and therefore we don't expect any external users to hit this bug.

@shati-patel shati-patel merged commit 9925b4e into main Sep 11, 2023
@shati-patel shati-patel deleted the v1.8.12 branch September 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants