Skip to content

Sort methods in usages panel according to model editor sort order #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

Sort methods in usages panel according to model editor sort order #2948

merged 2 commits into from
Oct 12, 2023

Conversation

@koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 11, 2023 •
edited
Loading

This sorts the methods in the methods usages panel the same as in the model editor. Since this is dependent on the mode, we need to keep track of the mode in the modeling store, so this also adds a mode field to the db state.

Somewhat dependent on #2949 since having two model editors open with different modes will result in a lot of potential error states.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Sort methods in usages panel according to model editor sort order
0e1afce 
This sorts the methods in the methods usages panel the same as in the
model editor. Since this is dependent on the mode, we need to keep track
of the mode in the modeling store, so this also adds a mode field to the
db state.
@koesie10 koesie10 marked this pull request as ready for review October 11, 2023 12:35
@koesie10 koesie10 requested a review from a team as a code owner October 11, 2023 12:35
charisk
charisk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

extensions/ql-vscode/src/model-editor/model-editor-module.ts
queryDir,
db,
modelFile,
Mode.Application,
Copy link
Contributor

@charisk charisk Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one bites the dust 😆

I love seeing the constructor getting smaller as we rely more on the modeling store.

@koesie10 koesie10 enabled auto-merge October 12, 2023 07:39
@koesie10 koesie10 merged commit 0835b14 into main Oct 12, 2023
@koesie10 koesie10 deleted the koesie10/sort-usages-panel branch October 12, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @charisk