Skip to content

Conversation

@koesie10
Copy link
Member

This will only allow opening a single model editor per database. When a new model editor is opened for which a model editor already exists, it will focus the existing one.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This will add checks in the appropriate places to ensure that only a
single model editor is opened per database.
This will change the model editor view tracker to only store 1 view per
database item instead of an array of views per database item.
@koesie10 koesie10 marked this pull request as ready for review October 11, 2023 10:28
@koesie10 koesie10 requested a review from a team as a code owner October 11, 2023 10:28
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koesie10 koesie10 merged commit 0d70022 into main Oct 12, 2023
@koesie10 koesie10 deleted the koesie10/single-model-editor-per-db branch October 12, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants