diff --git a/extensions/ql-vscode/src/view/compare/Compare.tsx b/extensions/ql-vscode/src/view/compare/Compare.tsx index 50a2d1b9f81..65e0a8ef3fe 100644 --- a/extensions/ql-vscode/src/view/compare/Compare.tsx +++ b/extensions/ql-vscode/src/view/compare/Compare.tsx @@ -1,5 +1,6 @@ import * as React from "react"; import { useState, useEffect } from "react"; +import { styled } from "styled-components"; import { ToCompareViewMessage, @@ -11,6 +12,18 @@ import CompareTable from "./CompareTable"; import "../results/resultsView.css"; +const Header = styled.div` + display: flex; +`; + +const HeaderTitle = styled.div` + margin: 0 1.5rem; +`; + +const Message = styled.div` + padding: 1.5rem; +`; + export function Compare(_: Record): JSX.Element { const [comparison, setComparison] = useState( null, @@ -49,8 +62,8 @@ export function Compare(_: Record): JSX.Element { try { return ( <> -
-
Comparing:
+
+ Comparing: ): JSX.Element { vscode.postMessage({ t: "changeCompare", newResultSetName }) } /> -
+ {hasRows ? ( ) : ( -
{message}
+ {message} )} ); diff --git a/extensions/ql-vscode/src/view/compare/CompareTable.tsx b/extensions/ql-vscode/src/view/compare/CompareTable.tsx index c53316ffb6d..29c1a79daa1 100644 --- a/extensions/ql-vscode/src/view/compare/CompareTable.tsx +++ b/extensions/ql-vscode/src/view/compare/CompareTable.tsx @@ -17,6 +17,15 @@ const OpenButton = styled(TextButton)` padding: 0; `; +const Table = styled.table` + margin: 20px 0; + width: 100%; + + & > tbody { + vertical-align: top; + } +`; + export default function CompareTable(props: Props) { const comparison = props.comparison; const result = props.comparison.result!; @@ -29,7 +38,7 @@ export default function CompareTable(props: Props) { } return ( - +
-
@@ -74,6 +83,6 @@ export default function CompareTable(props: Props) {
+ ); } diff --git a/extensions/ql-vscode/src/view/results/resultsView.css b/extensions/ql-vscode/src/view/results/resultsView.css index ca296638521..c1f52636ba6 100644 --- a/extensions/ql-vscode/src/view/results/resultsView.css +++ b/extensions/ql-vscode/src/view/results/resultsView.css @@ -168,27 +168,6 @@ td.vscode-codeql__path-index-cell { opacity: 0.6; } -.vscode-codeql__compare-header { - display: flex; -} - -.vscode-codeql__compare-header-item { - margin: 0 1.5rem; -} - -.vscode-codeql__compare-message { - padding: 1.5rem; -} - -.vscode-codeql__compare-body { - margin: 20px 0; - width: 100%; -} - -.vscode-codeql__compare-body > tbody { - vertical-align: top; -} - .vscode-codeql__empty-query-message { height: 300px; display: flex;