From caec6fb1097861b7570a4d9686b3d8d590d6d955 Mon Sep 17 00:00:00 2001 From: shati-patel <42641846+shati-patel@users.noreply.github.com> Date: Wed, 20 Mar 2024 12:46:19 +0000 Subject: [PATCH] Fix code scanning alert about duplicate command usage --- extensions/ql-vscode/src/common/commands.ts | 3 +++ .../src/model-editor/model-alerts/model-alerts-view.ts | 2 +- .../ql-vscode/src/variant-analysis/variant-analysis-manager.ts | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/common/commands.ts b/extensions/ql-vscode/src/common/commands.ts index ded87aea391..7b1cadcda7b 100644 --- a/extensions/ql-vscode/src/common/commands.ts +++ b/extensions/ql-vscode/src/common/commands.ts @@ -273,6 +273,9 @@ export type VariantAnalysisCommands = { "codeQL.openVariantAnalysisLogs": ( variantAnalysisId: number, ) => Promise; + "codeQLModelAlerts.openVariantAnalysisLogs": ( + variantAnalysisId: number, + ) => Promise; "codeQL.openVariantAnalysisView": ( variantAnalysisId: number, ) => Promise; diff --git a/extensions/ql-vscode/src/model-editor/model-alerts/model-alerts-view.ts b/extensions/ql-vscode/src/model-editor/model-alerts/model-alerts-view.ts index 098bf4b263a..6bb71dbfbad 100644 --- a/extensions/ql-vscode/src/model-editor/model-alerts/model-alerts-view.ts +++ b/extensions/ql-vscode/src/model-editor/model-alerts/model-alerts-view.ts @@ -93,7 +93,7 @@ export class ModelAlertsView extends AbstractWebview< break; case "openActionsLogs": await this.app.commands.execute( - "codeQL.openVariantAnalysisLogs", + "codeQLModelAlerts.openVariantAnalysisLogs", msg.variantAnalysisId, ); break; diff --git a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts index 184079d7f18..2b73c80c5d5 100644 --- a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts +++ b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts @@ -191,6 +191,8 @@ export class VariantAnalysisManager "codeQL.monitorReauthenticatedVariantAnalysis": this.monitorVariantAnalysis.bind(this), "codeQL.openVariantAnalysisLogs": this.openVariantAnalysisLogs.bind(this), + "codeQLModelAlerts.openVariantAnalysisLogs": + this.openVariantAnalysisLogs.bind(this), "codeQL.openVariantAnalysisView": this.showView.bind(this), "codeQL.runVariantAnalysis": this.runVariantAnalysisFromCommandPalette.bind(this),