From 7a367757ea0dc45b677556b8224a1d000b172e27 Mon Sep 17 00:00:00 2001 From: Taus Date: Thu, 14 Nov 2024 13:19:28 +0000 Subject: [PATCH 1/2] compare-perf: Add icons for positive/negative deltas Sadly there is no Unicode symbol for "green triangle down". --- .../src/view/compare-performance/ComparePerformance.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx b/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx index 74107a40374..97607136b56 100644 --- a/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx +++ b/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx @@ -92,10 +92,12 @@ function renderAbsoluteValue(x: OptionalValue) { function renderDelta(x: number) { const sign = x > 0 ? "+" : ""; + const symbol = x > 0 ? "🔺" : "🟢"; return ( {sign} {formatDecimal(x)} + {symbol} ); } From 50caa3c1dc635a4bb5c67984b1c2f0f37f04dff5 Mon Sep 17 00:00:00 2001 From: Taus Date: Thu, 14 Nov 2024 14:07:49 +0000 Subject: [PATCH 2/2] Use Codicons instead of emojis --- .../compare-performance/ComparePerformance.tsx | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx b/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx index 97607136b56..1a3c6eb3ed9 100644 --- a/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx +++ b/extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx @@ -90,9 +90,21 @@ function renderAbsoluteValue(x: OptionalValue) { } } +const DeltaPositive = styled(Codicon)` + color: var(--vscode-problemsErrorIcon-foreground); +`; + +const DeltaNegative = styled(Codicon)` + color: var(--vscode-problemsInfoIcon-foreground); +`; function renderDelta(x: number) { const sign = x > 0 ? "+" : ""; - const symbol = x > 0 ? "🔺" : "🟢"; + const symbol = + x > 0 ? ( + + ) : ( + + ); return ( {sign}