diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 41d1879da8b..1390cc6c272 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -8,6 +8,7 @@ - Alter structure of the _Test Explorer_ tree. It now follows the structure of the filesystem instead of the QL Packs. [#624](https://github.com/github/vscode-codeql/pull/624) - Add more structured output for tests. [#626](https://github.com/github/vscode-codeql/pull/626) - Whenever the extension restarts, orphaned databases will be cleaned up. These are databases whose files are located inside of the extension's storage area, but are not imported into the workspace. +- After renaming a database, the database list is re-sorted. [#685](https://github.com/github/vscode-codeql/pull/685) ## 1.3.6 - 4 November 2020 diff --git a/extensions/ql-vscode/src/databases-ui.ts b/extensions/ql-vscode/src/databases-ui.ts index 442c88c7b53..4a5b4fe2fcb 100644 --- a/extensions/ql-vscode/src/databases-ui.ts +++ b/extensions/ql-vscode/src/databases-ui.ts @@ -37,7 +37,7 @@ import { promptImportInternetDatabase, promptImportLgtmDatabase, } from './databaseFetcher'; -import { CancellationToken } from 'vscode-jsonrpc'; +import { CancellationToken } from 'vscode'; import { asyncFilter } from './pure/helpers-pure'; type ThemableIconPath = { light: string; dark: string } | string; diff --git a/extensions/ql-vscode/src/databases.ts b/extensions/ql-vscode/src/databases.ts index aeee0444819..d3c7e0591b2 100644 --- a/extensions/ql-vscode/src/databases.ts +++ b/extensions/ql-vscode/src/databases.ts @@ -667,7 +667,8 @@ export class DatabaseManager extends DisposableObject { item.name = newName; this.updatePersistedDatabaseList(); this._onDidChangeDatabaseItem.fire({ - item, + // pass undefined so that the entire tree is rebuilt in order to re-sort + item: undefined, kind: DatabaseEventKind.Rename }); } diff --git a/extensions/ql-vscode/src/vscode-tests/no-workspace/databases.test.ts b/extensions/ql-vscode/src/vscode-tests/no-workspace/databases.test.ts index 70dda617330..6bbbada3eb2 100644 --- a/extensions/ql-vscode/src/vscode-tests/no-workspace/databases.test.ts +++ b/extensions/ql-vscode/src/vscode-tests/no-workspace/databases.test.ts @@ -83,7 +83,7 @@ describe('databases', () => { expect(mockDbItem.name).to.eq('new name'); expect(updateSpy).to.have.been.calledWith('databaseList', ['new name']); expect(spy).to.have.been.calledWith({ - item: mockDbItem, + item: undefined, kind: DatabaseEventKind.Rename }); });