New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to graphql 0.12 #13

Merged
merged 4 commits into from Feb 27, 2018

Conversation

Projects
None yet
2 participants
@josh
Member

josh commented Jan 2, 2018

No description provided.

@josh

This comment has been minimized.

Show comment
Hide comment
@josh
Member

josh commented Jan 2, 2018

@josh

This comment has been minimized.

Show comment
Hide comment
@koddsson

This comment has been minimized.

Show comment
Hide comment
@koddsson

koddsson Jan 17, 2018

Contributor

There seems to be still a issue with relay-compiler-webpack-plugin?

Contributor

koddsson commented Jan 17, 2018

There seems to be still a issue with relay-compiler-webpack-plugin?

@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh Jan 17, 2018

Member

@koddsson oh nice, those packages are finally out!

There seems to be still a issue with relay-compiler-webpack-plugin?

Not sure, I'll try to investigate the build failure as well.

Member

josh commented Jan 17, 2018

@koddsson oh nice, those packages are finally out!

There seems to be still a issue with relay-compiler-webpack-plugin?

Not sure, I'll try to investigate the build failure as well.

Show outdated Hide outdated package.json Outdated
@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh Jan 17, 2018

Member

There seems to be still a issue with relay-compiler-webpack-plugin?

Yep,

https://github.com/danielholmes/relay-compiler-webpack-plugin/blob/8f2d776d6e9f03bc536f1caa1d1da3e405edc895/src/getSchema.js#L25

Needs to understand the new commentDescriptions flag.

Member

josh commented Jan 17, 2018

There seems to be still a issue with relay-compiler-webpack-plugin?

Yep,

https://github.com/danielholmes/relay-compiler-webpack-plugin/blob/8f2d776d6e9f03bc536f1caa1d1da3e405edc895/src/getSchema.js#L25

Needs to understand the new commentDescriptions flag.

@josh

This comment has been minimized.

Show comment
Hide comment
@josh
Member

josh commented Jan 17, 2018

@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh Jan 30, 2018

Member

Still blocked on babel-plugin-relay release.

Member

josh commented Jan 30, 2018

Still blocked on babel-plugin-relay release.

@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh Feb 26, 2018

Member

@koddsson want to have another look at this? I think some of these packages have been officially released.

Member

josh commented Feb 26, 2018

@koddsson want to have another look at this? I think some of these packages have been officially released.

koddsson added some commits Feb 27, 2018

fix leaf error
Relay throws a really weird error if a type doesn't have a ID field.
"Expected undefined to be a GraphQL leaf type."

This changes the `id` field to be of type `ID` instead of `String`.

See: facebook/relay#2281 (comment)
@koddsson

This comment has been minimized.

Show comment
Hide comment
Contributor

koddsson commented Feb 27, 2018

@koddsson

This comment has been minimized.

Show comment
Hide comment
@koddsson

koddsson Feb 27, 2018

Contributor

image

Contributor

koddsson commented Feb 27, 2018

image

@josh

This comment has been minimized.

Show comment
Hide comment
@josh

josh Feb 27, 2018

Member

omg, it's alive!

Member

josh commented Feb 27, 2018

omg, it's alive!

@josh josh merged commit 5550cb5 into master Feb 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@josh josh deleted the upgrade-graphql branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment