Skip to content

fix(safeoutputs): sanitize ADO-sourced title and tags in prefix-guard error messages to prevent VSO command injection #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 2 commits into from
May 1, 2026
Merged

fix(safeoutputs): sanitize ADO-sourced title and tags in prefix-guard error messages to prevent VSO command injection #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db9e54
Initial plan
Copilot May 1, 2026
f20cda2
fix(safeoutputs): sanitize ADO-sourced title and tags in prefix-guard…
Copilot May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/safeoutputs/update_work_item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,9 @@ async fn check_prefix_guards(
.and_then(|t| t.as_str())
.unwrap_or("");
if !current_title.starts_with(prefix.as_str()) {
let safe_title = sanitize_text(current_title);
return Ok(Some(ExecutionResult::failure(format!(
"Work item #{id} title '{current_title}' does not start with the required prefix '{prefix}' (configured in title-prefix)"
"Work item #{id} title '{safe_title}' does not start with the required prefix '{prefix}' (configured in title-prefix)"
))));
}
debug!("Title-prefix check passed: '{}'", current_title);
Expand All @@ -293,8 +294,9 @@ async fn check_prefix_guards(
.map(str::trim)
.any(|tag| tag.starts_with(prefix.as_str()));
if !has_matching_tag {
let safe_tags = sanitize_text(raw_tags);
return Ok(Some(ExecutionResult::failure(format!(
"Work item #{id} has no tag starting with '{prefix}' (configured in tag-prefix). Current tags: '{raw_tags}'"
"Work item #{id} has no tag starting with '{prefix}' (configured in tag-prefix). Current tags: '{safe_tags}'"
))));
}
debug!("Tag-prefix check passed; matched in tags: '{}'", raw_tags);
Expand Down