Skip to content

fix(safeoutputs): enforce add-build-tag scope for build IDs > i32::MAX #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 2 commits into from
May 1, 2026
Merged

fix(safeoutputs): enforce add-build-tag scope for build IDs > i32::MAX #379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
004a4ba
fix(safeoutputs): enforce add-build-tag scope for build IDs > i32::MAX
Copilot May 1, 2026
6e0dce7
refactor: simplify u64 cast in add-build-tag scope check
Copilot May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/safeoutputs/add_build_tag.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ impl Executor for AddBuildTagResult {
let config: AddBuildTagConfig = ctx.get_tool_config("add-build-tag");
debug!("Config: {:?}", config);

// 2b. Scope check: by default only the current build can be tagged
// 2b. Scope check: by default only the current build can be tagged.
// Compare in u64 space so that ADO build IDs larger than i32::MAX are
// still enforced (the agent-supplied i32 simply cannot match such
// values, which is the desired behavior).
if !config.allow_any_build {
// Pulled from ctx (sourced from BUILD_BUILDID); narrowed to i32 to
// match the agent-supplied build_id type.
let current_build_id: Option<i32> = ctx
.build_id
.and_then(|id| i32::try_from(id).ok());
if let Some(current_id) = current_build_id {
if self.build_id != current_id {
if let Some(current_id) = ctx.build_id {
// self.build_id is validated > 0, so the cast to u64 is exact;
// values that don't fit in i32 simply cannot match current_id.
if self.build_id as u64 != current_id {
return Ok(ExecutionResult::failure(format!(
"Build #{} cannot be tagged: only the current build (#{}) is \
allowed unless 'allow-any-build: true' is configured",
Expand Down