docs(site): fix pool default and add missing pipeline filter fields in front-matter reference#644
Merged
jamesadevine merged 1 commit intoMay 19, 2026
Conversation
…n front-matter reference - Correct the pool example: replace stale 'AZS-1ES-L-MMS-ubuntu-22.04' string default with accurate vmImage: ubuntu-22.04 (Microsoft-hosted) form, and add commented alternatives for self-hosted string, self-hosted object, and 1ES. - Add branch, build-reason, and expression to the pipeline.filters example; all three are present in PipelineFilters struct (types.rs) and the repo docs but were absent from the site page, while the 'Expression Escape Hatch' and 'Filter Validation' prose sections already referenced them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vmImage: ubuntu-22.04as the non-1ES default, matching code behavior. The previous example used a bare 1ES pool name string which misled users into thinking that was the default Microsoft-hosted pool.pipeline.filtersexample now shows all five supported fields (source-pipeline,branch,time-window,build-reason,expression). Three were missing even though the prose sections ("Expression Escape Hatch", "Filter Validation") already referenced them.Changes
site/src/content/docs/reference/front-matter.mdx— two targeted corrections to the comprehensive front matter exampleAccuracy checks
src/compile/types.rsPoolConfig::default()returnsPoolConfigFull { vm_image: Some("ubuntu-22.04") }— confirmed the default is Microsoft-hostedvmImage: ubuntu-22.04, not the 1ES pool namePoolConfigFullstruct hasname,vmImage,os— the old example only showedname+osand omittedvmImageentirelyPipelineFiltersstruct (types.rs:1093–1109) hastime_window,source_pipeline,branch,build_reason,expression— all five, only two were in the exampledocs/front-matter.mdshows all three missing fields (branch,build-reason,expression) in the pipeline filters blockValidation
cd site && npm ci && npm run build— 28 pages built, all internal links validCreated by the docs-writer workflow.