style(clippy): fix test file lints (zombie_processes, empty_line_after_doc_comment, useless_format, unused_variable)#674
Merged
jamesadevine merged 1 commit intoMay 21, 2026
Conversation
…r_doc_comment, useless_format, unused_variable) - tests/mcp_http_tests.rs: change module-level /// to // to fix empty_line_after_doc_comment; add child.wait().ok() before panic to fix zombie_processes (all code paths must wait on spawned child) - tests/compiler_tests.rs: prefix unused output_yaml with _ to fix fix useless_format Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What clippy found
Running
cargo clippy --all-targets --all-features --workspace -- -D warningsreported four findings in the test files:How it was fixed
clippy::empty_line_after_doc_commenttests/mcp_http_tests.rs///to//— the block describes the test module, not a specific item, so//is correctclippy::zombie_processestests/mcp_http_tests.rschild.wait().ok()afterchild.kill().ok()before thepanic!so all code paths reap the child processclippy::unused_variablestests/compiler_tests.rsoutput_yamlwith_to signal intentional non-useclippy::useless_formattests/compiler_tests.rs&format!("\"source\":\"")with the string literal"\"source\":\""directlyVerification
cargo build --all-targets: ✅ succeededcargo test --test mcp_http_tests: ✅ 8 passed, 0 failedcargo test --test compiler_tests: ✅ 116 passed, 0 failedcargo clippy --all-targets --all-features --workspace -- -D warnings: ✅ no new warnings in the changed files