Skip to content

style(clippy): fix test file lints (zombie_processes, empty_line_after_doc_comment, useless_format, unused_variable) #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
May 21, 2026
Merged

style(clippy): fix test file lints (zombie_processes, empty_line_after_doc_comment, useless_format, unused_variable) #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/compiler_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ This is a test agent for integration testing.
fs::create_dir_all(temp_dir.join(".github/agents")).expect("Failed to create .github/agents");

// Run the compilation
let output_yaml = temp_dir.join("test-agent.yml");
let _output_yaml = temp_dir.join("test-agent.yml");

// Note: We can't directly call compile_pipeline from here since it's not a library function
// This test verifies the output structure when compile runs
Expand Down Expand Up @@ -3730,7 +3730,7 @@ fn assert_marker_step_present(
"{fixture_name}: marker line missing schema=1: {line}"
);
assert!(
line.contains(&format!("\"source\":\"")) && line.contains(expected_source_suffix),
line.contains("\"source\":\"") && line.contains(expected_source_suffix),
"{fixture_name}: marker line does not include source suffix {expected_source_suffix}: {line}"
);
// The runtime echo on the next line should mirror the same data
Expand Down
11 changes: 6 additions & 5 deletions tests/mcp_http_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ use std::io::BufRead;
use std::process::{Child, Command, Stdio};
use std::time::Duration;

/// Integration tests for the SafeOutputs HTTP server (`mcp-http` subcommand).
///
/// These tests validate the HTTP transport layer that MCPG uses to reach
/// SafeOutputs. They do NOT require Docker or the MCPG gateway — they test
/// the ado-aw HTTP server directly.
// Integration tests for the SafeOutputs HTTP server (`mcp-http` subcommand).
//
// These tests validate the HTTP transport layer that MCPG uses to reach
// SafeOutputs. They do NOT require Docker or the MCPG gateway — they test
// the ado-aw HTTP server directly.

/// Guard that kills the child process on drop (even on panic).
struct ServerGuard {
Expand Down Expand Up @@ -94,6 +94,7 @@ fn start_server() -> ServerGuard {
}
// Kill and panic if not ready
child.kill().ok();
child.wait().ok();
panic!("SafeOutputs HTTP server did not become ready within 5 s");
}

Expand Down