docs(site): fix FileGlobMatch — gate.js globMatch, not python3 fnmatch#837
Merged
jamesadevine merged 1 commit intoJun 3, 2026
Conversation
- Corrected the 'Bash Shape' entry for FileGlobMatch from 'python3 `fnmatch`' to 'gate.js `globMatch`'; the evaluator is TypeScript/Node.js, not Python. - Added cross-reference link to the ado-script reference page in the 'Bundled Gate Evaluator' section. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
deleted the
docs/fix-filter-ir-fileglobmatch-python3-1780451012-68533f7a7e715717
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileGlobMatchwas described as using "python3fnmatch", but the actual evaluator is the TypeScript/Node.jsgate.jsbundle which uses its ownglobMatch()function — Python is not involved.Changes
site/src/content/docs/reference/filter-ir.mdx: correctedFileGlobMatch"Bash Shape" entry; added ado-script reference link.Accuracy checks
scripts/ado-script/src/gate/predicates.ts: bothglob_match(case "glob_match") andfile_glob_match(case "file_glob_match") are handled by the JavaScriptglobMatch()function — no Python code anywhere in the gate evaluator.src/compile/filter_ir.rsline 173 comment:fnmatch(value, pattern)refers to the semantic shape, not a Python call; gate.js implements the same semantics via a custom regex.Validation
cd site && npm ci && npm run buildCreated by the docs-writer workflow.