test: fix incorrect and vacuous tests in create_git_tag and create_issue

[github-actions]

Test Suite Reduction: src/safeoutputs/create_git_tag.rs + src/safeoutputs/create_issue.rs

What was wrong

• test_validation_rejects_empty_tag (create_git_tag.rs): The test name claims it verifies rejection of an empty tag name, but the body supplies "ab" (a 2-character string). The code path being exercised is the "too short" validation (tag_name.len() >= 3), not the empty-string case. This is an incorrect test — name describes feature A, body exercises feature B.

• test_result_requires_write (create_issue.rs): The entire body is const _: () = assert!(CreateIssueResult::REQUIRES_WRITE). This is a compile-time constant assertion that always evaluates to assert!(true) at runtime — completely vacuous as a test. Additionally, CreateIssueResult was the only write-requiring tool not listed in the centralized test_requires_write_consistency guard in mod.rs.

Changes

File	Test	Action	Reason
create_git_tag.rs	test_validation_rejects_empty_tag	Renamed → test_validation_rejects_too_short_tag	Name was incorrect — body tests 2-char input, not empty
create_issue.rs	test_result_requires_write	Removed	Vacuous: const assert always passes at runtime
mod.rs	test_requires_write_consistency	Added CreateIssueResult entry	Ensures the REQUIRES_WRITE invariant is centrally guarded

Verification

• cargo test: 1759 unit tests + all integration tests pass ✅
• No regressions introduced ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• spsprodeus21.vssps.visualstudio.com
• spsprodweu4.vssps.visualstudio.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "spsprodeus21.vssps.visualstudio.com"
    - "spsprodweu4.vssps.visualstudio.com"

See Network Configuration for more information.

Generated by Test Reducer · sonnet46 1.9M · ◷