From 13c3bd5855e8f1afa4245c244399d11f2a94bb8a Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 3 Jun 2026 01:47:15 +0000
Subject: [PATCH] test: fix incorrect and vacuous tests in create_git_tag and
 create_issue
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- create_git_tag.rs: rename test_validation_rejects_empty_tag to
  test_validation_rejects_too_short_tag — body uses "ab" (2 chars),
  not an empty string; the name was incorrect.
- create_issue.rs: remove test_result_requires_write — it contained only
  a const assertion (always passes at runtime, vacuous).
- mod.rs: add CreateIssueResult to the centralized
  test_requires_write_consistency so the REQUIRES_WRITE invariant is
  actually guarded alongside every other write-requiring tool.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 src/safeoutputs/create_git_tag.rs | 2 +-
 src/safeoutputs/create_issue.rs   | 5 -----
 src/safeoutputs/mod.rs            | 1 +
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/safeoutputs/create_git_tag.rs b/src/safeoutputs/create_git_tag.rs
index 24c76122..8f7df197 100644
--- a/src/safeoutputs/create_git_tag.rs
+++ b/src/safeoutputs/create_git_tag.rs
@@ -422,7 +422,7 @@ mod tests {
     }
 
     #[test]
-    fn test_validation_rejects_empty_tag() {
+    fn test_validation_rejects_too_short_tag() {
         let params = CreateGitTagParams {
             tag_name: "ab".to_string(),
             commit: None,
diff --git a/src/safeoutputs/create_issue.rs b/src/safeoutputs/create_issue.rs
index 941a476b..76ac9d05 100644
--- a/src/safeoutputs/create_issue.rs
+++ b/src/safeoutputs/create_issue.rs
@@ -455,11 +455,6 @@ mod tests {
         assert_eq!(CreateIssueResult::NAME, "create-issue");
     }
 
-    #[test]
-    fn test_result_requires_write() {
-        const _: () = assert!(CreateIssueResult::REQUIRES_WRITE);
-    }
-
     #[test]
     fn test_validate_rejects_short_title() {
         let params = CreateIssueParams {
diff --git a/src/safeoutputs/mod.rs b/src/safeoutputs/mod.rs
index 13bc896a..0cbc6b7b 100644
--- a/src/safeoutputs/mod.rs
+++ b/src/safeoutputs/mod.rs
@@ -840,6 +840,7 @@ mod tests {
     #[test]
     fn test_requires_write_consistency() {
         // Write-requiring tools
+        const { assert!(CreateIssueResult::REQUIRES_WRITE); }
         const { assert!(CreateWorkItemResult::REQUIRES_WRITE); }
         const { assert!(CommentOnWorkItemResult::REQUIRES_WRITE); }
         const { assert!(UpdateWorkItemResult::REQUIRES_WRITE); }