Skip to content

docs(site): fix permissions.write — executor defaults to System.AccessToken#890

Merged
jamesadevine merged 1 commit into
mainfrom
docs/fix-permissions-write-optional-634cc572bfd5d7bb
Jun 7, 2026
Merged

docs(site): fix permissions.write — executor defaults to System.AccessToken#890
jamesadevine merged 1 commit into
mainfrom
docs/fix-permissions-write-optional-634cc572bfd5d7bb

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Users no longer see inaccurate guidance saying permissions.write is required for safe outputs or that compilation fails without it
  • The permission combinations table now correctly shows all four configurations — including the (common) case where neither service connection is set but safe outputs still work via $(System.AccessToken)
  • The {{ executor_ado_env }} template-marker description now accurately reflects that the env: block is always emitted

Changes

  • site/src/content/docs/reference/network.mdx:
    • Removed stale claim "System.AccessToken is never used for agent or executor operations"
    • Rewrote intro paragraph and Note block to reflect Stage 3 using $(System.AccessToken) as its default write token
    • Updated Security Model: permissions.write is now documented as optional override for cross-org / named-identity writes
    • Removed the incorrect "Compile-Time Validation" section
    • Updated examples to include the default no-SC case
  • site/src/content/docs/setup/service-connections.mdx:
    • Changed table row from "Write (required for safe outputs)" → "Write (optional override)"
    • Changed section description from "minimum required connection" → explains when to use an override
    • Replaced incorrect "compile-time safety check" callout with an accurate "Default executor token" note
    • Fixed permission combinations table: Only read and Neither rows now correctly show writes as ✅ (with clarifying labels)
  • site/src/content/docs/reference/template-markers.mdx:
    • Rewrote {{ executor_ado_env }} description: env block is always emitted, not only when permissions.write is set

Accuracy checks

  • src/compile/common.rs generate_executor_ado_env() (lines 1769–1797): always pushes SYSTEM_ACCESSTOKEN — confirmed always-emitted behavior
  • Test at line 6162: "Should always emit env: block (executor needs SYSTEM_ACCESSTOKEN)" — confirmed
  • Test at line 6165: "Default executor token is $(System.AccessToken)" — confirmed default path
  • Test at line 6139: "Executor should use SC_WRITE_TOKEN when write SC is configured" — confirmed override path
  • PR feat(compile): default executor to System.AccessToken and add always-on Azure CLI #873 description: validate_write_permissions deleted — confirmed compilation no longer fails without permissions.write

Validation

  • cd site && npm ci && npm run build — 33 pages built, all internal links valid

Created by the docs-writer workflow.

Generated by Docs Writer · sonnet46 3M ·

…sToken

- network.mdx: remove stale "System.AccessToken is never used for
  executor operations" claim; update Security Model to show
  permissions.write is optional (override); remove incorrect
  Compile-Time Validation section; add a fourth example for the
  default no-SC case
- service-connections.mdx: change "Write (required for safe outputs)"
  table row to "optional override"; drop "minimum required connection"
  framing; replace incorrect compile-time-failure callout with an
  accurate Default executor token note; fix permission combinations
  table (Only read / Neither rows now correctly show writes as ✅)
- template-markers.mdx: rewrite {{ executor_ado_env }} — env block is
  always emitted, not only when permissions.write is set

Verified against generate_executor_ado_env() in src/compile/common.rs
(lines 1769-1797 and companion tests at lines 6139-6203).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine marked this pull request as ready for review June 7, 2026 16:55
@jamesadevine jamesadevine merged commit af084e6 into main Jun 7, 2026
@jamesadevine jamesadevine deleted the docs/fix-permissions-write-optional-634cc572bfd5d7bb branch June 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant