Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Conversation

@mattdavis0351
Copy link
Contributor

This PR gives the Docker image a more unique name to avoid conflict with other courses that rely on Docker images stored using packages

@github-learning-lab
Copy link

Your draft course version was created!


You can edit it using the Course Builder UI!

@brianamarie
Copy link
Contributor

This change makes sense to me, @mattdavis0351! I trust that you've gone through and tested that it works - do you want someone else to verify this works as a part of the whole course? If not, I think this is good to 🚢!

@mattdavis0351
Copy link
Contributor Author

@brianamarie @hectorsector I don't have an AWS account setup, could someone that does do a quick run through to make sure this naming change didn't hurt anything

@brianamarie
Copy link
Contributor

@brianamarie @hectorsector I don't have an AWS account setup, could someone that does do a quick run through to make sure this naming change didn't hurt anything

I can go through this on Thursday or Friday, but @hectorsector may be able to get to it sooner 😊

Copy link
Member

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple enough fix, merging and I'm going through the course now anyway for other reasons.

@hectorsector hectorsector merged commit af90bdc into master Mar 25, 2020
@hectorsector hectorsector deleted the docker-image-name-change branch March 25, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants