From b4c14d433b9e57be3dd7b7cfd86c380ce28141c8 Mon Sep 17 00:00:00 2001 From: Eric Amodio Date: Sun, 3 Jun 2018 21:43:01 -0400 Subject: [PATCH] Fixes #391 - historyExplorer.enabled always gets set --- CHANGELOG.md | 4 ++++ src/configuration.ts | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 933da3d2b240..2226ee5d9de4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] +### Fixed +- Fixes [#391](https://github.com/eamodio/vscode-gitlens/issues/391) - GitLens adds some settings in settings.json + ## [8.3.3] - 2018-05-31 ### Added - Adds (re-adds) support for handling single files — closes [#321](https://github.com/eamodio/vscode-gitlens/issues/321) diff --git a/src/configuration.ts b/src/configuration.ts index 9a7e2bb1f095..94aed0c0a3a4 100644 --- a/src/configuration.ts +++ b/src/configuration.ts @@ -210,7 +210,7 @@ export class Configuration { await configuration.update(section, value, ConfigurationTarget.Workspace); } else { - if (inspect.globalValue === value) return; + if (inspect.globalValue === value || (inspect.globalValue === undefined && inspect.defaultValue === value)) return; await configuration.update(section, value, ConfigurationTarget.Global); } }