Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Last fetched" message is also updated when fetch failed #1016

Closed
amfasis opened this issue May 1, 2020 · 2 comments
Closed

"Last fetched" message is also updated when fetch failed #1016

amfasis opened this issue May 1, 2020 · 2 comments
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@amfasis
Copy link

amfasis commented May 1, 2020

  • GitLens Version: 10.2.1
  • VSCode Version:
    Version: 1.44.2
    Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
    Date: 2020-04-16T17:50:03.709Z
    Electron: 7.1.11
    Chrome: 78.0.3904.130
    Node.js: 12.8.1
    V8: 7.8.279.23-electron.0
    OS: Linux x64 4.9.0-8-amd64
  • OS Version: Linux NB-BV009 4.9.0-8-amd64 Support blame on files outside the workspace repository #1 SMP Debian 4.9.144-3.1 (2019-02-19) x86_64 GNU/Linux

Steps to Reproduce:

  1. Clone a repository which is only available locally, such as in a company network.
  2. Fetch when not connected to the company network.

Observed:
"Last Fetched" will be updated to current date, however in the GitLens debug output the following can be seen:

[4a7d] GitService.fetchAll — e=myrepo, t={"all":false,"prune":false}
[4a7e] Repository(/media/work/source/myrepo/).fetch — {"all":false,"prune":false}
[4a7f] GitService.fetch — e=/media/work/Source/myrepo, t={"all":false,"prune":false}
[4a7d] GitService.fetchAll completed • 50 ms
[4a7a] GitCommandsCommand.execute completed
[/media/work/Source/myrepo] Git Command failed: /usr/bin/git -c core.quotepath=false -c color.ui=false fetch • ssh: Could not resolve hostname gitlab.<company>.com: Name or service not known • Could not read from remote repository. •  • Please make sure you have the correct access rights • and the repository exists. • 161 ms
[/media/work/Source/myrepo] git fetch • 161 ms 
[4a7f] GitService.fetch completed • 167 ms
[4a7e] Repository(/media/work/source/myrepo/).fetch completed • 171 ms

Expected:
"Last Fetched" status message shows "Last Fetched failed" or is not updated to current time

@eamodio
Copy link
Member

eamodio commented Dec 23, 2020

This has been resolved in the latest insiders edition (should be coming to stable soon).

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@eamodio eamodio closed this as completed Dec 23, 2020
@eamodio eamodio added bug Something isn't working needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition and removed potential-bug labels Dec 23, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 23, 2020
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants