Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stash all changes has no effect when the number of files is large #1183

Closed
AlCalzone opened this issue Nov 19, 2020 · 5 comments
Closed

stash all changes has no effect when the number of files is large #1183

AlCalzone opened this issue Nov 19, 2020 · 5 comments
Assignees
Labels
bug Something isn't working verified Verified
Milestone

Comments

@AlCalzone
Copy link

  • GitLens Version: 11.0.1
  • Git Version: 2.28.0.windows.1
  • VS Code version: Code 1.51.0 (fcac248b077b55bae4ba5bab613fd6e9156c2f0c, 2020-11-05T18:18:23.642Z)
  • OS version: Windows_NT x64 10.0.19041

Steps to Reproduce:

  1. Have a bunch of changes
  2. Click the icon for stash all changes
  3. Enter stash message
  4. nothing happens

ezgif-6-3a999e679625

It does seem to work if the number of changes is small (a handful of files). The 215 files above seem to be to much.

(originally reported in microsoft/vscode#110390)

@eamodio eamodio added bug Something isn't working good first issue Good for newcomers help wanted Want community input and/or pull request and removed type: potential bug labels Nov 22, 2020
@eamodio eamodio added this to the Soonish™ milestone Nov 29, 2020
@eamodio
Copy link
Member

eamodio commented Nov 29, 2020

We should add a warning when the number of files it too large for git to handle on the command line.

@eamodio eamodio self-assigned this Jan 8, 2021
@eamodio eamodio closed this as completed in 3509a3a Jan 8, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition and removed good first issue Good for newcomers help wanted Want community input and/or pull request labels Jan 8, 2021
@eamodio eamodio modified the milestones: Soonish™, Soon™ Jan 8, 2021
@eamodio
Copy link
Member

eamodio commented Jan 8, 2021

So now if you are on Git 2.30.0 or later, this will just work. But if not, and you try to stage too many files (the number is highly variable as it depends on the path lengths), you will get an error saying:

Stashing so many files (<number>) at once requires a newer version of Git (>= 2.30.0) than is currently installed (<installed-git-version>). Please retry by stashing fewer files or install a more recent version of Git.

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@AlCalzone
Copy link
Author

Will do!

@AlCalzone
Copy link
Author

Seems to work:
grafik

@eamodio eamodio added verified Verified and removed needs-verification Request for community verification labels Jan 8, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Feb 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified Verified
Projects
None yet
Development

No branches or pull requests

2 participants