Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting heatmap's coldColor and hotColor breaks file blame & related functionality #1205

Closed
robertrossmann opened this issue Nov 23, 2020 · 2 comments
Closed

Setting heatmap's coldColor and hotColor breaks file blame & related functionality #1205

robertrossmann opened this issue Nov 23, 2020 · 2 comments
Assignees
@eamodio
Labels
bug Something isn't working

Comments

@robertrossmann
Copy link

  • GitLens Version: 11.0.5
  • Git Version: N/A
  • VSCode Version: 1.51.1
  • OS Version: macOS 11.0.1

Steps to Reproduce:

  1. Set a non-default value for either gitlens.heatmap.coldColor or gitlens.heatmap.hotColor
  2. Toggle File Blame Annotations
  3. Observe no blame annotations appearing in current file
  4. Observe the following error message in GitLens' Output panel:
TypeError: (intermediate value).scale is not a function

When these two colour values do not match the defaults the code branches here. For some reason the imported chroma-js module does not have a .scale() function which causes this error. I am not sure what's happening with that module, why the .scale function is not available. 🤷‍♂️
@eamodio eamodio added bug Something isn't working and removed type: potential bug labels Nov 28, 2020
@eamodio eamodio self-assigned this Nov 28, 2020
@eamodio eamodio added this to the Soon™ milestone Nov 28, 2020
@robertrossmann
Copy link
Author

😍 👍

@eamodio eamodio removed this from the Soon™ milestone Dec 2, 2020
@github-actions
Copy link

github-actions bot commented Jan 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @robertrossmann