Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stashes list doesn't refresh on deletion #1212

Closed
ahmed2m opened this issue Nov 25, 2020 · 6 comments
Closed

Stashes list doesn't refresh on deletion #1212

ahmed2m opened this issue Nov 25, 2020 · 6 comments
Assignees
Labels
bug Something isn't working verified Verified
Milestone

Comments

@ahmed2m
Copy link

ahmed2m commented Nov 25, 2020

When I delete a stash it does that successfully but if I delete another one I get the error

Unable to delete stash. See output channel for more details

And in the GitLens output

[2020-11-25 17:51:56:758] Drop Stash
Error: Unable to delete stash; mismatch with stash number

Only when I click refresh on the stashes tab deleting a stash will work again

@eamodio
Copy link
Member

eamodio commented Nov 28, 2020

Hrm, I'm not experiencing this issue. So my guess is this has to do with an issue with file watching. Does this happen all the time? What OS are you on and VS Code version? Also is there anything special about your repo? Do other GitLens views auto-refresh properly? Does the VS Code SCM view update properly?

@eamodio eamodio added the needs-more-info Needs further information, steps, details, etc. label Nov 28, 2020
@eamodio
Copy link
Member

eamodio commented Nov 28, 2020

Also it might help to get logs. Please enable output channel logging by setting "gitlens.outputLevel": "debug" in your settings. This will enable logging to the GitLens channel in the Output pane. Once enabled, please reproduce the issue and attach the log from the GitLens channel.

@ahmed2m
Copy link
Author

ahmed2m commented Nov 28, 2020

OS: Linux x64 5.9.10-1-MANJARO
VSCode Version: 1.51.1
I don't think any gitlens view is being refreshed or changed when I do anything without refreshing the view myself (or going to any other tab then back to SC tab).

Having you mentioned if anything is special with the repo itself. I have the idea that it maybe because I have the repo opened in a code workspace with the repo root being one folder and children as other folders (children are normal folders not git repos).
I made a dummy repo with the .code-workspace file to be opened and reproduce the issue.
https://github.com/Ahmeed2m/gitlens-issue/
image
The delete logs are also in that repo https://github.com/Ahmeed2m/gitlens-issue/blob/master/log

@eamodio eamodio added bug Something isn't working and removed needs-more-info Needs further information, steps, details, etc. type: potential bug labels Nov 29, 2020
@eamodio eamodio self-assigned this Nov 29, 2020
@eamodio eamodio added this to the Soon™ milestone Nov 29, 2020
@eamodio eamodio added the needs-verification Request for community verification label Nov 29, 2020
@eamodio
Copy link
Member

eamodio commented Nov 29, 2020

@Ahmeed2m Thank you so much for the test repo -- that helped a ton!

Can you please verify this fix in the latest insiders version?

You can install the insiders version from here.

@eamodio eamodio reopened this Nov 29, 2020
@ahmed2m
Copy link
Author

ahmed2m commented Nov 30, 2020

Thank you @eamodio for the fix, I've used the insiders version all day yesterday and so far it seems to be working great in my workspace.

@eamodio eamodio added pending-release Resolved but not yet released to the stable edition verified Verified and removed needs-verification Request for community verification labels Dec 4, 2020
@eamodio eamodio closed this as completed Dec 6, 2020
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified Verified
Projects
None yet
Development

No branches or pull requests

2 participants