Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit pane, ${tips} does not show tags #1223

Closed
diablodale opened this issue Nov 30, 2020 · 2 comments
Closed

commit pane, ${tips} does not show tags #1223

diablodale opened this issue Nov 30, 2020 · 2 comments
Assignees
Labels
bug Something isn't working needs-verification Indicates a request for community verification
Milestone

Comments

@diablodale
Copy link

diablodale commented Nov 30, 2020

Hi. In COMMITS pane, the default ${❰ tips ❱➤ } shows branches but does not show tags.
The circled commit below appears in both COMMITS and TAGS pane. However, the COMMITS pane only shows master and does not show master, v1.3.20201027

image

I am expecting ${tips} to do as its documentation writes. To show branches and tags at a commit.
Also expecting it to show the same information as in a git log. Here is that log for this same commit

image

Setup

  • GitLens Version: 11.0.6
  • Git Version: git version 2.29.2
  • Version: 1.51.1 (system setup)
  • Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
  • Date: 2020-11-10T23:34:32.027Z
  • Electron: 9.3.3
  • Chrome: 83.0.4103.122
  • Node.js: 12.14.1
  • V8: 8.3.110.13-electron.0
  • OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

  1. Setup OS, vscode, git, and extensions as above
  2. Setup gpg signing. Set commit.gpgSign, tag.gpgSign, and tag.forceSignAnnotated all true in git global user settings.
  3. Make commits on master branch
  4. Tag last commit
  5. Make new branch foobar, checkout foobar
  6. Make several commits
  7. Switch to source control section in vscode
  8. open COMMITS pane and view the entry for the commit that was tagged in step 4

Result

The commit in the COMMITS pane shows only master

Expected

The commit in the COMMITS pane to show master and the tag made in step 4

@diablodale diablodale added the potential-bug Seems like something isn't working label Nov 30, 2020
@eamodio eamodio added bug Something isn't working and removed potential-bug Seems like something isn't working labels Dec 1, 2020
@eamodio eamodio self-assigned this Dec 1, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 1, 2020
@eamodio eamodio added the needs-verification Indicates a request for community verification label Dec 1, 2020
@eamodio eamodio closed this as completed in 659a216 Dec 1, 2020
@eamodio eamodio reopened this Dec 1, 2020
@eamodio
Copy link
Member

eamodio commented Dec 1, 2020

Can you please verify this fix in tomorrow's insiders edition? Be sure to disable/uninstall the stable version of GitLens first.

You can install the insiders edition from here.

@eamodio eamodio added the pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition label Dec 4, 2020
@eamodio eamodio closed this as completed Dec 6, 2020
@eamodio eamodio removed the pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Indicates a request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants