Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitLab rich integration #1236

Closed
kpaxton opened this issue Dec 4, 2020 · 8 comments
Closed

Add GitLab rich integration #1236

kpaxton opened this issue Dec 4, 2020 · 8 comments
Assignees
Labels
feature New feature or request verified ✔ Verified
Milestone

Comments

@kpaxton
Copy link

kpaxton commented Dec 4, 2020

My company has a privately hosted GitLab instance. I read in the docs that the Pull-Requests should be visible in the Commits View, but I'm not seeing them. I've set up the domain and type in the gitlens.remotes settings, but I am not seeing any Merge Requests in the view.

Is there something else I need to set up for this to work or is GitLab not fully supported for that feater?

@eamodio eamodio added feature New feature or request help wanted Want community input and/or pull request needs-champion Needs a community champion to move this forward and removed question labels Dec 4, 2020
@eamodio
Copy link
Member

eamodio commented Dec 4, 2020

The rich integration support is currently only implemented for GitHub, but its extensible to support any remote provider. So if someone would create a PR to talk to the GitLab (or BitBucket, AzureDev Ops, etc) APIs it could be integrated. But it is unlikely that I will add that support myself, as I don't use the other providers and it would take a lot of time for me to setup and test.

@kpaxton
Copy link
Author

kpaxton commented Dec 7, 2020 via email

@eamodio
Copy link
Member

eamodio commented Dec 7, 2020

Just to be clear, I'd love to have support for other providers -- and would definitely help anyone who wants to start on this.

@kpaxton
Copy link
Author

kpaxton commented Dec 9, 2020

I can take a look, but I can't guarantee anything time wise.

One thing I do notice right now is that GitLab's GraphQL interface doesn't seem to be full-fledged. So is there an http client that you would prefer using instead of the native http client or just use the native?

What's the best way to communicate with you if I have questions?
@eamodio

@eamodio
Copy link
Member

eamodio commented Dec 9, 2020

Thanks -- let me know if you need any help or have any questions.

If the GraphQL support won't work, I would recommend using the node-fetch library, that way we can work in the desktop and browser.

You can join the VS Code Development Community Slack or we can use the newly enabled GitHub Discussions on this repo.

@kpaxton
Copy link
Author

kpaxton commented Dec 10, 2020 via email

@eamodio eamodio added this to the Backlog milestone Dec 16, 2020
kpaxton pushed a commit to kpaxton/vscode-gitlens that referenced this issue Dec 17, 2020
* Add GitLab api-v4 support
* Add Personal Token authorization for GitLab Remotes
* Add IgnoreCertErrors remote config param for allowing invalid certs
* Add node-fetch for non-graphql APIs
@eamodio eamodio changed the title GitLab Merge Request support? Add GitLab rich integration Dec 23, 2020
kpaxton pushed a commit to kpaxton/vscode-gitlens that referenced this issue Apr 12, 2021
* Add GitLab api-v4 support
* Add Personal Token authorization for GitLab Remotes
* Add IgnoreCertErrors remote config param for allowing invalid certs
* Add node-fetch for non-graphql APIs
kpaxton pushed a commit to kpaxton/vscode-gitlens that referenced this issue Apr 12, 2021
* Add GitLab api-v4 support
* Add Personal Token authorization for GitLab Remotes
* Add IgnoreCertErrors remote config param for allowing invalid certs
* Add node-fetch for non-graphql APIs
@eamodio eamodio modified the milestones: Backlog, 12.1 Jun 13, 2022
@eamodio eamodio self-assigned this Jun 13, 2022
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification and removed help wanted Want community input and/or pull request needs-champion Needs a community champion to move this forward labels Jun 13, 2022
@eamodio
Copy link
Member

eamodio commented Jun 13, 2022

Closed by fd61e1d

@eamodio eamodio closed this as completed Jun 13, 2022
@d13 d13 added verified ✔ Verified and removed needs-verification Request for community verification labels Jun 13, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants