Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutter Blame avatar does not use Gravatar fallback style #1246

Closed
Konsonanz opened this issue Dec 8, 2020 · 4 comments
Closed

Gutter Blame avatar does not use Gravatar fallback style #1246

Konsonanz opened this issue Dec 8, 2020 · 4 comments
Assignees
Labels
bug Something isn't working verified Verified
Milestone

Comments

@Konsonanz
Copy link

Description:

As of GitLens Version 11+, the Gutter Blame fallback avatar does not use the Gravatar fallback style anymore, but rather the same blue-white icon for every commit. All other gitlens avatar displays (hover, sidemenu etc.) seem to still use the Gravatar fallback.
This is for me an inconsistency issue (between gutter and hover at least), as well as a comfort issue as I mostly work with an on premises git hosting solution which does not support user avatars and since now every author avatar uses one and the same fallback icon I can not visually distinguish different authors anymore.

Environment:

  • GitLens Version: 11.0.6
  • Git Version: 2.29.2
  • VSCode Version: 1.52.0-insider (bc13785d3d) x64
  • OS Version: Ubuntu 20.04.1 LTS

Steps to Reproduce:

  1. Start Visual Studio Code with a new user profile (for testing, I ran mv "~/.config/Code - Insiders" "~/.config/Code - InsidersBAK", prompting Visual Studio Code to create a new user profile on start)
  2. Create a new test repository without a remote
$ mkdir /tmp/gitlens-test
$ cd /tmp/gitlens-test
$ git init
$ echo "test" > README.MD
$ git add -a
$ git commit -m "Initial commit"
  1. Open the new repository and file and activate line blame:
    Bildschirmfoto von 2020-12-08 13-38-40

Expected Behaviour:

I expect the Gutter Blame avatar to use the same Gravatar fallback as the Hover Avatar.

Observed Behaviour

The Gutter Blame avatar shows a different fallback as the Hover Avatar and does not respect the gitlens.defaultGravatarStyle setting.

@eamodio eamodio added bug Something isn't working and removed type: potential bug labels Dec 10, 2020
@eamodio eamodio self-assigned this Dec 10, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 10, 2020
@eamodio eamodio added the needs-verification Request for community verification label Dec 10, 2020
@eamodio
Copy link
Member

eamodio commented Dec 10, 2020

Can you please verify this fix in today's insiders edition? Be sure to disable/uninstall the stable version of GitLens first.

You can install the insiders edition from here.

@Konsonanz
Copy link
Author

Tested OK and can confirm as fixed with Gitlens (Insiders) Version: 2020.12.1005.

Thank you very much for the quick fix. Love the extension!

@eamodio
Copy link
Member

eamodio commented Dec 10, 2020

Thank you for verifing!

@eamodio eamodio added pending-release Resolved but not yet released to the stable edition verified Verified and removed needs-verification Request for community verification labels Dec 10, 2020
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified Verified
Projects
None yet
Development

No branches or pull requests

2 participants