Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository folders are missing repository actions (e.g. favorites, close repo, etc) #1255

Closed
eamodio opened this issue Dec 10, 2020 · 4 comments
Assignees
Labels
bug Something isn't working verified Indicates that the issue has been community verified
Milestone

Comments

@eamodio
Copy link
Member

eamodio commented Dec 10, 2020

Originally posted by @plwalsh in #1252

@eamodio eamodio added the bug Something isn't working label Dec 10, 2020
@eamodio eamodio added this to the Soon™ milestone Dec 10, 2020
@eamodio eamodio self-assigned this Dec 10, 2020
@eamodio eamodio added the needs-verification Indicates a request for community verification label Dec 10, 2020
@eamodio
Copy link
Member Author

eamodio commented Dec 10, 2020

@plwalsh There are now actions on each repository folder in the view, with additional commands for favoriting (which controls ordering) and you can close the repo as well.

Can you please verify this fix in today's insiders edition? Be sure to disable/uninstall the stable version of GitLens first.

You can install the insiders edition from here.

@plwalsh
Copy link

plwalsh commented Dec 10, 2020

That works! Closing the repo removes it immediately, and keeps it removed for any future file-openings from that repo for the current vscode instance. If vscode is closed and reopened, the repo will again show up the next time a file from that repo is opened, requiring you to repeat the process of closing it. Is that intended? (I think that's in-line with the built-in Source Control view, but I just wanted to make sure it's working as intended.) If so, would it make sense to add a setting for a list of always ignored repos?

Adding a repo to favorites immediately moves that repo to the top of the list, as expected. This option, however, does stick across a closing and reopening of vscode. In a new instance of vscode, opening a file from that same other repo will place the repo at the top of the list, with the context menu option to "Remove from Favorites". Is that intended?

Thanks for addressing this so quickly!

@eamodio
Copy link
Member Author

eamodio commented Dec 10, 2020

@plwalsh Thank you! Yup that is exactly the intended behavior of both options!

As for a setting to ignore repositories -- that is a good idea, that I thought I had implemented, but apparently not. Opened #1259 to track it

@eamodio eamodio added verified Indicates that the issue has been community verified pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition and removed needs-verification Indicates a request for community verification labels Dec 10, 2020
@eamodio eamodio removed the pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition label Dec 24, 2020
@eamodio eamodio modified the milestones: Soon™, Shipped Dec 24, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified Indicates that the issue has been community verified
Projects
None yet
Development

No branches or pull requests

2 participants