Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome screen on every editor window is very tedious #1302

Closed
jlaxson opened this issue Jan 2, 2021 · 5 comments
Closed

Welcome screen on every editor window is very tedious #1302

jlaxson opened this issue Jan 2, 2021 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jlaxson
Copy link

jlaxson commented Jan 2, 2021

I just discovered Gitlens and find the functionality useful, thank you to all who contribute.

I have about a dozen editor windows open, and the install process added a Gitlens welcome tab to each and every one of them. Combined with the snowflake effect, all of the sudden VScode was consuming 300-400% cpu and my fan was raging, as soon as I hunted them all down everything was back to fine. The welcome note content is great (although putting it on all the windows is a bit much, don't know how much control you have on that). But overall it was a bit of a sour first-use experience, just wanted to provide that feedback.

@jlaxson jlaxson added feature New feature or request triage Needs to be looked at labels Jan 2, 2021
@eamodio
Copy link
Member

eamodio commented Jan 2, 2021

@jlaxson

First sorry about that -- definitely not an ideal (nor desired) first experience 😢

Just to be clear when you say editor windows open -- you mean new vscode windows, right?

Unfortunately, I don't really have good control over that, since it seems like a timing issue -- where each window checks to see if this is a "first-install" and if so shows the welcome experience.

I'll have to think about this some more.

Maybe I could only show the welcome experience if the window is focused (I actually have access to that state, and event when it changes), and only on the first focused one.

@eamodio eamodio added bug Something isn't working and removed feature New feature or request triage Needs to be looked at labels Jan 2, 2021
@eamodio eamodio self-assigned this Jan 2, 2021
@eamodio eamodio added this to the Soon™ milestone Jan 2, 2021
@eamodio eamodio closed this as completed in f9c2bec Jan 3, 2021
@eamodio
Copy link
Member

eamodio commented Jan 3, 2021

I've changed it so the welcome experience & what's new notification to only show on the first focused window after install.

@eamodio
Copy link
Member

eamodio commented Jan 3, 2021

@jlaxson Thanks so much for the report -- I never even thought about anything like this.

@eamodio eamodio added the pending-release Resolved but not yet released to the stable edition label Jan 3, 2021
@jlaxson
Copy link
Author

jlaxson commented Jan 3, 2021

@eamodio Thanks a lot, glad I could be helpful and there was a workable fix. Vscode windows are to me what chrome tabs are to some others, so can see that I might be a bit of an extreme case. Cheers!

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Jan 3, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Jan 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants