Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open on Remote is creating invalid URLs for Azure Devops #1303

Closed
travatomic opened this issue Jan 3, 2021 · 5 comments · Fixed by #1304
Closed

Open on Remote is creating invalid URLs for Azure Devops #1303

travatomic opened this issue Jan 3, 2021 · 5 comments · Fixed by #1304
Assignees
@eamodio
Labels
bug Something isn't working verified ✔ Indicates that the issue has been community verified
Milestone
Shipped

Comments

@travatomic
Copy link
Contributor

travatomic commented Jan 3, 2021 •
edited

  • GitLens Version: 11.1.2 (also main branch)
  • Git Version: git version 2.30.0.windows.1
  • VSCode Version: 1.52.1 / ea3859d4ba2f3e577a159bc91e3074c5d85c0523 / x64
  • OS Version: Windows 10 1909

Steps to Reproduce:

  1. Clone an Azure Devops repo that includes a space escaped as %20. example: git clone https://DataLinkSoftware@dev.azure.com/DataLinkSoftware/Cloud%20Infrastructure/_git/Azure_Infrastructure
  2. In VSCode, go to source control -> remotes -> click the globe next to the repo to "Open Repository on Remote"
  3. The browser will open to the URL:
    https://dev.azure.com/DataLinkSoftware/Cloud%2520Infrastructure/_git/Azure_Infrastructure which is a 404, because the % being re-encoded as %25

Expected URL:
https://dev.azure.com/DataLinkSoftware/Cloud%20Infrastructure/_git/Azure_Infrastructure
Actual URL:
https://dev.azure.com/DataLinkSoftware/Cloud%2520Infrastructure/_git/Azure_Infrastructure

Another way to reproduce:

  1. Clone any repro on Azure Devops
  2. In VSCode, go to Explorer and right click any file and choose "Open File on Remote"
  3. In my case, I did this with a README.md in the root, and this is the url that was sent to my browser:
    https://dev.azure.com/DataLinkSoftware/Core/_git/Sso/?path=%252FREADME.md&version=GBmaster&_a=contents which is a 404.

Expected URL:
https://dev.azure.com/DataLinkSoftware/Core/_git/Sso/?path=%2FREADME.md&version=GBmaster&_a=contents
or
https://dev.azure.com/DataLinkSoftware/Core/_git/Sso/?path=/README.md&version=GBmaster&_a=contents
Actual URL:
https://dev.azure.com/DataLinkSoftware/Core/_git/Sso/?path=%252FREADME.md&version=GBmaster&_a=contents

These were regressions introduced in 545dc4a which was created to address #1202. I will be submitting a PR to fix this.
@travatomic travatomic added potential-bug Seems like something isn't working triage Indicates that this issue needs triaging labels Jan 3, 2021
travatomic added a commit to travatomic/vscode-gitlens that referenced this issue Jan 3, 2021
@travatomic
Fixes gitkraken#1303: Fix remote URLs for Azure DevOps
7488a35
@travatomic travatomic mentioned this issue Jan 3, 2021
Merged
7 tasks
eamodio pushed a commit that referenced this issue Jan 4, 2021
@travatomic @eamodio
Fixes #1303: Fix remote URLs for Azure DevOps
9b90b30
@eamodio
Copy link
Member

eamodio commented Jan 4, 2021

@TravisTX awesome work -- I will get this into a release ASAP!

@eamodio eamodio added bug Something isn't working and removed potential-bug Seems like something isn't working triage Indicates that this issue needs triaging labels Jan 4, 2021
@eamodio eamodio self-assigned this Jan 4, 2021
@eamodio eamodio added this to the Soon™ milestone Jan 4, 2021
@eamodio eamodio added needs-verification Indicates a request for community verification pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition labels Jan 4, 2021
@eamodio
Copy link
Member

eamodio commented Jan 4, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@travatomic
Copy link
Contributor Author

@eamodio looks good!

@eamodio
Copy link
Member

eamodio commented Jan 5, 2021

Thanks!

@eamodio eamodio added verified ✔ Indicates that the issue has been community verified and removed needs-verification Indicates a request for community verification labels Jan 5, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Jan 6, 2021
@eamodio eamodio removed the pending-release Indicates that the issue been resolved, but has not yet been released to the stable edition label Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Feb 6, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working verified ✔ Indicates that the issue has been community verified
Projects
None yet
Milestone
Shipped
Development

Successfully merging a pull request may close this issue.

Fixes #1303: Fix remote URLs for Azure DevOps travatomic/vscode-gitlens
2 participants
@eamodio @travatomic