Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape quotes for PRs titles #1308

Closed
ahmed2m opened this issue Jan 6, 2021 · 3 comments
Closed

Escape quotes for PRs titles #1308

ahmed2m opened this issue Jan 6, 2021 · 3 comments
Assignees
@eamodio
Labels
bug Something isn't working verified ✔ Verified
Milestone
Shipped

Comments

@ahmed2m
Copy link

ahmed2m commented Jan 6, 2021

  • GitLens Version: v2021.1.504
  • Git Version: 2.29.2
  • VSCode Version: 1.52.1
  • OS Version: Linux Manjaro Kernel 5.10.2-2

I've used a tiny reproduction repo for this issue https://github.com/ahmed2m/gitlens-issue

Steps to Reproduce:

  1. Clone the repo above.
  2. open folder-1 > readme.md
  3. hover to get the gitlens tooltip on any part of any line.
  4. The link part that supposed to say via PR #1 is messed up because of unescaped string (the PR title has double quotes in it)
    image

Here's the text from the screenshot:

via [PR #1](command:gitlens.action.openPullRequest?%7B%22pullRequest%22%3A%7B%22id%22%3A%221%22%2C%22provider%22%3A%22GitHub%22%2C%22repoPath%22%3A%22%2Fhome%2Fahmed%2Fplayground%2Fgitlens-issue%22%2C%22url%22%3A%22https%3A%2F%2Fgithub.com%2Fahmed2m%2Fgitlens-issue%2Fpull%2F1%22%7D%2C%22type%22%3A%22openPullRequest%22%7D "Open Pull Request #1 on GitHub —— very "important" feature Merged, 20 minutes ago")   (January 6th, 2021 1:40am)
@ahmed2m ahmed2m added potential-bug triage Needs to be looked at labels Jan 6, 2021
@eamodio eamodio closed this as completed in 72327e6 Jan 6, 2021
@eamodio eamodio added bug Something isn't working needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition and removed potential-bug triage Needs to be looked at labels Jan 6, 2021
@eamodio eamodio self-assigned this Jan 6, 2021
@eamodio eamodio added this to the Soon™ milestone Jan 6, 2021
@eamodio
Copy link
Member

eamodio commented Jan 6, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@ahmed2m
Copy link
Author

ahmed2m commented Jan 7, 2021

@eamodio It's fixed for me now on v2021.1.604
Thank you.

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Jan 7, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Feb 3, 2021
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Feb 9, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Milestone
Shipped
Development

No branches or pull requests
2 participants
@eamodio @ahmed2m