Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Rebase Editor not opened but plain text file when called from terminal #1442

Closed
universam1 opened this issue Mar 24, 2021 · 4 comments
Assignees
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@universam1
Copy link

Calling "Rebase current branch onto Commit" as "interactive" opens the "Interactive Rebase Editor" just fine. The command executed under the hood in the terminal is git -c sequence.editor="code --wait --reuse-window" rebase --interactive e2db9b3b250adc217665d30640c16f2fdfe774c8
However, pasting the same command in the terminal again does not open that editor, it just opens VSCode as a plain text file!

The same problem applies when running git rebase -i from terminal, just a plain text file is opened in VSCode, no Interactive Editor.

  • GitLens Version: 11.3.0
  • Git Version: Run git --version 2.25.1
  • VSCode Version: Run code --version 1.54.3
  • OS Version: Ubuntu 20.04.2 LTS

Steps to Reproduce:

  1. set up git to use VScode as editor
[core]
	editor = code --wait
  1. run git rebase -i ...
  2. vscode opens git-rebase-todo as plain text file

Errors seen:

[2021-03-24 09:02:22:953] [/home/..../.git/rebase-merge] git rev-parse --show-toplevel • FAILED 8 ms 

Error: Command failed: /usr/bin/git -c core.quotepath=false -c color.ui=false rev-parse --show-toplevel
fatal: this operation must be run in a work tree
@universam1 universam1 added potential-bug triage Needs to be looked at labels Mar 24, 2021
@eamodio
Copy link
Member

eamodio commented Mar 29, 2021

Is this under WSL or are you on Ubuntu natively?

@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Mar 29, 2021
@eamodio eamodio self-assigned this Mar 29, 2021
@eamodio eamodio added this to the Soon™ milestone Mar 29, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Mar 29, 2021
@eamodio
Copy link
Member

eamodio commented Mar 29, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@universam1
Copy link
Author

Is this under WSL or are you on Ubuntu natively?

native Ubuntu

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Apr 9, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Apr 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants