Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VSCodium in interactive rebase editor #1473

Closed
jingyu9575 opened this issue Apr 20, 2021 · 9 comments
Closed

Support VSCodium in interactive rebase editor #1473

jingyu9575 opened this issue Apr 20, 2021 · 9 comments
Assignees
Labels
feature New feature or request verified ✔ Verified
Milestone

Comments

@jingyu9575
Copy link

jingyu9575 commented Apr 20, 2021

VSCodium is an open source build of vscode, and this extension works well on it. However, it uses the command codium instead of code and the interactive rebase editor is not launching.

Could you add a branch to the appName switch:

https://github.com/eamodio/vscode-gitlens/blob/2b8a300703103b12ab90b17e1ad0a2d6c9ece1e6/src/commands/git/rebase.ts#L81-L91

 	case 'VSCodium': 
 		editor = 'codium --wait --reuse-window'; 
 		break; 

Thank you!

@jingyu9575 jingyu9575 added feature New feature or request triage Needs to be looked at labels Apr 20, 2021
@matronator
Copy link

Duplicate #1430

@jingyu9575
Copy link
Author

jingyu9575 commented Apr 22, 2021

@matronator I think this issue about the launch command is easier to implement than Github auth in #1430. It only needs a branch in the switch code.

@pmahend1
Copy link

pmahend1 commented Jun 3, 2021

I don't think this logic will work for authentication provision #1430 , it involves redirection code.

@earthnuker
Copy link

VSCodium is an open source build of vscode, and this extension works well on it. However, it uses the command codium instead of code and the interactive rebase editor is not launching.

Could you add a branch to the appName switch:

https://github.com/eamodio/vscode-gitlens/blob/2b8a300703103b12ab90b17e1ad0a2d6c9ece1e6/src/commands/git/rebase.ts#L81-L91

 	case 'VSCodium': 
 		editor = 'codium --wait --reuse-window'; 
 		break; 

Thank you!

I just tested the change suggested here and it works without issue, i don't see what authentication has to do with this since git rebase only modifies the local repository and does not talk to the remote

Best regards,

Earthnuker

@diggit
Copy link

diggit commented Nov 26, 2021

I've also stumbled on this issue.
Hard coding executable names seems too fragile to me.
At least default should be empty so git configuration may work as fallback. User might have configured sequence.editor.
Or expose executable name through extension config.

@eamodio eamodio removed the triage Needs to be looked at label Dec 22, 2021
@eamodio eamodio self-assigned this Dec 22, 2021
@eamodio eamodio added this to the Soon™ milestone Dec 22, 2021
@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

Fixed in 9994e13

@eamodio eamodio closed this as completed Dec 22, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Dec 22, 2021
@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@pmahend1
Copy link

@eamodio thanks. I did a quick test on preview version and this seems to be working fine.

git -c sequence.editor="codium --wait --reuse-window" rebase --interactive blahblahblacksheep
hint: Waiting for your editor to close the file... 

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for community verification labels Dec 24, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 1, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

6 participants