Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced regular expression search in changes #1572

Closed
tormozit opened this issue Jul 9, 2021 · 4 comments
Closed

Forced regular expression search in changes #1572

tormozit opened this issue Jul 9, 2021 · 4 comments
Assignees
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@tormozit
Copy link

tormozit commented Jul 9, 2021

  • GitLens Version: v11.5.1
  • OS Version: Windows 10
  • VS Code Version: 1.58.0 (user setup)
    Electron: 12.0.13
    Chrome: 89.0.4389.128
    Node.js: 14.16.0

Steps to Reproduce:

  1. In Visual Studio Code connect to cloned repository from https://github.com/tormozit/RDT1C
  2. Open GitLens/Search&Compare/Search in changes
  3. Turn Off "Regular expression mode"
  4. Type "div|p|b"
  5. Run command
    изображение

I get billion of results instead of just several. It looks like "Regular expression mode" is always ON even if switch is OFF.

@tormozit tormozit added potential-bug triage Needs to be looked at labels Jul 9, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Dec 22, 2021
@eamodio eamodio self-assigned this Dec 22, 2021
@eamodio eamodio added this to the Soon™ milestone Dec 22, 2021
@eamodio eamodio added needs-verification Request for community verification pending-release Resolved but not yet released to the stable edition labels Dec 22, 2021
@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

This should largely be resolved, but unfortunately turning the regex on and off will have more of an effect and just not using a regex to match should. This is because Git doesn't seem to support searching in diffs for literal strings (only regex via the -G flag to git log), but it can search for occurrence differences of literal strings (via the -S flag to git log).

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@tormozit
Copy link
Author

Disabled stable GitLens version. Installed GitLens Insiders version. Problem reproduced
изображение

@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

@tormozit Sorry for the confusion, but the latest insiders isn't out just yet (should be published in the next 10m). It will be version 2021.12.22*

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Mar 1, 2022
@eamodio eamodio modified the milestones: Soon™, Shipped Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

No branches or pull requests

2 participants