Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should hide the context menu on unrelated tabs. #1583

Closed
tamuratak opened this issue Jul 21, 2021 · 2 comments · Fixed by #1589
Closed

Should hide the context menu on unrelated tabs. #1583

tamuratak opened this issue Jul 21, 2021 · 2 comments · Fixed by #1589
Assignees
Labels
bug Something isn't working needs-verification Request for community verification
Milestone

Comments

@tamuratak
Copy link
Contributor

  • GitLens Version: 11.6.0
  • Git Version: git version 2.21.1 (Apple Git-122.3)

Version: 1.59.0-insider
Commit: b805d2e94937976bb17d0439f57fcd3a9d423c31
Date: 2021-07-20T05:12:13.059Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 18.7.0

Steps to Reproduce:

  1. Open Settings Panel.
  2. Right-click the tab of the panel.
  3. GitLens context menus appear.

We should hide the context menu on unrelated tabs.

スクリーンショット 2021-07-21 14 56 37

I think it is enough to add isFileSystemResource to when clauses. I would make a PR if it would be acceptable.

--- a/package.json
+++ b/package.json
@@ -6752,39 +6752,39 @@
                        "editor/title/context": [
                                {
                                        "command": "gitlens.copyRemoteFileUrlWithoutRange",
-                                       "when": "gitlens:enabled && gitlens:hasRemotes && config.gitlens.menus.editorTab.clipboard",
+                                       "when": "gitlens:enabled && gitlens:hasRemotes && config.gitlens.menus.editorTab.clipboard && isFileSystemResource",
                                        "group": "1_cutcopypaste@100"
                                },
                                {
                                        "submenu": "gitlens/editor/changes",
-                                       "when": "gitlens:enabled && config.gitlens.menus.editorTab.compare",
+                                       "when": "gitlens:enabled && config.gitlens.menus.editorTab.compare && isFileSystemResource",
                                        "group": "2_gitlens@0"
                                },
@tamuratak tamuratak added potential-bug triage Needs to be looked at labels Jul 21, 2021
tamuratak added a commit to tamuratak/vscode-gitlens that referenced this issue Jul 26, 2021
tamuratak added a commit to tamuratak/vscode-gitlens that referenced this issue Oct 9, 2021
tamuratak added a commit to tamuratak/vscode-gitlens that referenced this issue Oct 26, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Nov 3, 2021
@eamodio eamodio self-assigned this Nov 3, 2021
@eamodio eamodio added this to the Soon™ milestone Nov 3, 2021
@eamodio eamodio added pending-release Resolved but not yet released to the stable edition needs-verification Request for community verification labels Nov 3, 2021
@eamodio
Copy link
Member

eamodio commented Nov 3, 2021

Can you please verify this fix in tomorrow's GitLens insiders edition?

You can install the GitLens insiders edition from here.

Please be sure to disable or uninstall the stable version of GitLens first.

@eamodio eamodio removed the pending-release Resolved but not yet released to the stable edition label Nov 19, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Nov 19, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-verification Request for community verification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants